threads / patch / 26488

patchgit-gui: document the gui.maxfilesdisplayed variable

Subject: [PATCH] git-gui: document the gui.maxfilesdisplayed variable

## tl;dr

5 messages between Feb 13, 2011 and Feb 14, 2011. Diffs are folded; open one to read it.

replies: 4people: 4as markdown or json

Heiko Voigt· Feb 13, 2011, 12:53 UTC · lore
This removes a TODO item in the git-gui source.
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
I am not sure how we should go about this patch. Should I split it in
two since it removes the TODO line in git-gui and adds the
documentation in git?
Cheers Heiko
 Documentation/config.txt |    5 +++++
 git-gui/git-gui.sh       |    1 -
 2 files changed, 5 insertions(+), 1 deletions(-)
Show changes to 2 files +5 −1

Documentation/config.txt, git-gui/git-gui.sh

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 722e00a..d8edeeb 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -1122,6 +1122,11 @@ gui.matchtrackingbranch::
 	default to tracking remote branches with matching names or
 	not. Default: "false".
 
+gui.maxfilesdisplayed::
+	Configures the amount of changed files after which git gui will
+	issue a warning that there are more changes than can be
+	displayed.
+
 gui.newbranchtemplate::
 	Is used as suggested name when creating new branches using the
 	linkgit:git-gui[1].
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index e03eda0..db09f00 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -838,7 +838,6 @@ set default_config(gui.newbranchtemplate) {}
 set default_config(gui.spellingdictionary) {}
 set default_config(gui.fontui) [font configure font_ui]
 set default_config(gui.fontdiff) [font configure font_diff]
-# TODO: this option should be added to the git-config documentation
 set default_config(gui.maxfilesdisplayed) 5000
 set default_config(gui.usettk) 1
 set default_config(gui.warndetachedcommit) 1

-- 
1.7.4.rc3.4.g155c4
Junio C Hamano· Feb 14, 2011, 07:51 UTC · re: Heiko Voigt · lore

Re: [PATCH] git-gui: document the gui.maxfilesdisplayed variable

Heiko Voigt <hvoigt@hvoigt.net> writes:
> I am not sure how we should go about this patch. Should I split it in
> two since it removes the TODO line in git-gui and adds the
> documentation in git?
Two opposing thoughts.
 1. We can keep git-gui and git proper separate projects, move git-gui
    documentation out of git to git-gui, and with clever Makefile trick
    include and build git-gui related documentation conditionally only
    when git-gui appears part of the git project tree (this anticipates a
    future where git-gui is bound to git not with the subtree merge
    strategy as we currently do, but as a submodule).
 2. Just like the Linux kernel project, we can make each subsystem with
    separate maintainers just different repositories of the same git
    project with their own focus.  We already do this for git-svn (which I
    delegate to Eric Wong by pulling from him) and some parts of contrib/
    tree; we have already been halfway there for gitweb/ (which I don't
    regularly "pull from", but I mainly act as a patch monkey without
    actively managing that part myself).  I don't see why we cannot extend
    that model to git-gui and gitk.
Heiko Voigt· Feb 14, 2011, 22:03 UTC · re: Junio C Hamano · lore

future of git-gui as subsytem or submodule, WAS: [PATCH] git-gui: document the gui.maxfilesdisplayed variable

Hi,
On Sun, Feb 13, 2011 at 11:51:04PM -0800, Junio C Hamano wrote:
Show 17 quoted lines
> Two opposing thoughts.
> 
>  1. We can keep git-gui and git proper separate projects, move git-gui
>     documentation out of git to git-gui, and with clever Makefile trick
>     include and build git-gui related documentation conditionally only
>     when git-gui appears part of the git project tree (this anticipates a
>     future where git-gui is bound to git not with the subtree merge
>     strategy as we currently do, but as a submodule).
> 
>  2. Just like the Linux kernel project, we can make each subsystem with
>     separate maintainers just different repositories of the same git
>     project with their own focus.  We already do this for git-svn (which I
>     delegate to Eric Wong by pulling from him) and some parts of contrib/
>     tree; we have already been halfway there for gitweb/ (which I don't
>     regularly "pull from", but I mainly act as a patch monkey without
>     actively managing that part myself).  I don't see why we cannot extend
>     that model to git-gui and gitk.

I would vote for 2. Not because I think submodules will not become as easy to use so they are ready for that but I think there are mainly two reasons for using a submodule

  A. The submodule contains shared code which is used by multiple projects
  B. A submodule is used to keep large collection of files seperate from
     a project because most times they are not needed and would
     interfere with the project.

There are maybe more but these two do not apply to git-gui and I like the way it is currently integrated in one repository with git. It also underlines the fact that git-gui is AFAICS the standard and best developed gui for git.

Another plus, if we extend that model to gitk, is that both could start sharing code between each other (maybe relocate to the same directory).

Although 1. would be a good choice for getting more people involved in enhancing submodule support, from a philosophical standpoint, I think 2. is the more natural choice.

What do others think?
Cheers Heiko
Jonathan Nieder· Feb 14, 2011, 22:17 UTC · re: Heiko Voigt · lore

Re: future of git-gui as subsytem or submodule

Hi,
Two quick thoughts.
Heiko Voigt wrote:
> On Sun, Feb 13, 2011 at 11:51:04PM -0800, Junio C Hamano wrote:
>>  2. Just like the Linux kernel project, we can make each subsystem with
>>     separate maintainers just different repositories of the same git
>>     project with their own focus.  We already do this for git-svn (which I
[...]
> Another plus, if we extend that model to gitk, is that both could start
> sharing code between each other (maybe relocate to the same directory).

I think historically Paul has tried to maintain compatibility with older git versions in gitk, to allow it to be used as a separate project.

A dream would be for gitk and hgk to share code, but I'm not sure anyone has even tried a proof-of-concept for that.

Jens Lehmann· Feb 14, 2011, 22:46 UTC · re: Heiko Voigt · lore

Re: future of git-gui as subsytem or submodule, WAS: [PATCH] git-gui: document the gui.maxfilesdisplayed variable

Am 14.02.2011 23:03, schrieb Heiko Voigt:
Show 28 quoted lines
> On Sun, Feb 13, 2011 at 11:51:04PM -0800, Junio C Hamano wrote:
>> Two opposing thoughts.
>>
>>  1. We can keep git-gui and git proper separate projects, move git-gui
>>     documentation out of git to git-gui, and with clever Makefile trick
>>     include and build git-gui related documentation conditionally only
>>     when git-gui appears part of the git project tree (this anticipates a
>>     future where git-gui is bound to git not with the subtree merge
>>     strategy as we currently do, but as a submodule).
>>
>>  2. Just like the Linux kernel project, we can make each subsystem with
>>     separate maintainers just different repositories of the same git
>>     project with their own focus.  We already do this for git-svn (which I
>>     delegate to Eric Wong by pulling from him) and some parts of contrib/
>>     tree; we have already been halfway there for gitweb/ (which I don't
>>     regularly "pull from", but I mainly act as a patch monkey without
>>     actively managing that part myself).  I don't see why we cannot extend
>>     that model to git-gui and gitk.
> 
> I would vote for 2. Not because I think submodules will not become as easy to
> use so they are ready for that but I think there are mainly two reasons
> for using a submodule
> 
>   A. The submodule contains shared code which is used by multiple projects
> 
>   B. A submodule is used to keep large collection of files seperate from
>      a project because most times they are not needed and would
>      interfere with the project.
C. The subproject is developed by someone else, is not under the
   administrative control of the superproject, and follows a different
   release cycle. (as seen on the Git Wiki ;-)

I don't have strong feelings about this choice, but because of the way git-gui and gitk are developed at the moment 1) seems more appropriate right now. But this is Pat's and Paul's call, as they have to agree with the choice taken and choosing 2) might tie those guis more to a specific git version than they might be comfortable with. But I'm just guessing here ...

Show 7 quoted lines
> There are maybe more but these two do not apply to git-gui and I like
> the way it is currently integrated in one repository with git. It also
> underlines the fact that git-gui is AFAICS the standard and best
> developed gui for git.
> 
> Another plus, if we extend that model to gitk, is that both could start
> sharing code between each other (maybe relocate to the same directory).
That is an advantage of approach 2).
> Although 1. would be a good choice for getting more people involved in
> enhancing submodule support, from a philosophical standpoint, I think 2.
> is the more natural choice.

I don't think "getting more people involved in enhancing submodule support" is a strong argument here. We should choose that policy which supports the development culture of the projects in question.

← back to recent threads