threads / patch / 2648

patchFixed git:// IPv4 address problem when compiled with -DNO_IPV6.

Subject: [PATCH] Fixed git:// IPv4 address problem when compiled with -DNO_IPV6.

## tl;dr

One message between Nov 22, 2005 and Nov 22, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Paul Serice· Nov 22, 2005, 13:54 UTC · lore

Failure to dereference a pointer caused incorrect initialization of the IPv4 address when calling connect() when compiled with -DNO_IPV6.

With this patch and yesterday's patch for git-daemon, it should now be possible to use the native git protocol for both the client and server on Cygwin.

Signed-off-by: Paul Serice <paul@serice.net>
---
 connect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applies-to: 5bc7f67c535dbbbb9340285c82226a8dd6e4afec b16765657940be2f4d14e8f1e65d35e4b32bea0f

Show changes to connect.c +1 −1
diff --git a/connect.c b/connect.c
index 7a417e5..93f6f80 100644
--- a/connect.c
+++ b/connect.c
@@ -427,7 +427,7 @@ static int git_tcp_connect(int fd[2], co
 		memset(&sa, 0, sizeof sa);
 		sa.sin_family = he->h_addrtype;
 		sa.sin_port = htons(nport);
-		memcpy(&sa.sin_addr, ap, he->h_length);
+		memcpy(&sa.sin_addr, *ap, he->h_length);
 
 		if (connect(sockfd, (struct sockaddr *)&sa, sizeof sa) < 0) {
 			close(sockfd);
---
0.99.9.GIT

← back to recent threads