threads / patch / 26430

patchgit-gui: instead of defaulting to home directory use working directory

Subject: [PATCH] git-gui: instead of defaulting to home directory use working directory

## tl;dr

2 messages between Feb 6, 2011 and Feb 6, 2011. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Heiko Voigt· Feb 6, 2011, 17:22 UTC · lore

When starting git gui in a non-git directory it presents the user a dialog which asks to create, clone or open a repository. The filedialogs used to choose the path(s) would always default to the home directory of the user. This patch changes this behavior and uses the current working directory in which git gui was started as default.

This is useful in various cases. First being that the user starts the gui in some directory and can go search to create, open or clone a repository from there. Another use case is that tools like filemanager context menues can transport a natural default when selected from a folder.

Users who like to have their home folder as a default can fall back on starting git gui with its working directory set to the home folder.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 lib/choose_repository.tcl |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)
Show changes to lib/choose_repository.tcl +3 −11
diff --git a/lib/choose_repository.tcl b/lib/choose_repository.tcl
index fae1192..657f7d5 100644
--- a/lib/choose_repository.tcl
+++ b/lib/choose_repository.tcl
@@ -214,14 +214,6 @@ constructor pick {} {
 	}
 }
 
-proc _home {} {
-	if {[catch {set h $::env(HOME)}]
-		|| ![file isdirectory $h]} {
-		set h .
-	}
-	return $h
-}
-
 method _center {} {
 	set nx [winfo reqwidth $top]
 	set ny [winfo reqheight $top]
@@ -420,7 +412,7 @@ method _new_local_path {} {
 	if {$local_path ne {}} {
 		set p [file dirname $local_path]
 	} else {
-		set p [_home]
+		set p [pwd]
 	}
 
 	set p [tk_chooseDirectory \
@@ -541,7 +533,7 @@ method _open_origin {} {
 	if {$origin_url ne {} && [file isdirectory $origin_url]} {
 		set p $origin_url
 	} else {
-		set p [_home]
+		set p [pwd]
 	}
 
 	set p [tk_chooseDirectory \
@@ -1042,7 +1034,7 @@ method _open_local_path {} {
 	if {$local_path ne {}} {
 		set p $local_path
 	} else {
-		set p [_home]
+		set p [pwd]
 	}
 
 	set p [tk_chooseDirectory \
-- 
1.7.4.34.gd2cb1
Pat Thoyts· Feb 6, 2011, 23:01 UTC · re: Heiko Voigt · lore

Re: [PATCH] git-gui: instead of defaulting to home directory use working directory

All three patches are fine - thank you.
 git-gui: instead of defaulting to home directory use working directory
 git-gui: scroll down to default selection for push dialog
 git gui: keep selected branch when remote is changed in push dialog
all applied.

← back to recent threads