threads / patch / 26428

patchgit gui: keep selected branch when remote is changed in push dialog

Subject: [PATCH] git gui: keep selected branch when remote is changed in push dialog

## tl;dr

One message between Feb 6, 2011 and Feb 6, 2011. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Heiko Voigt· Feb 6, 2011, 17:01 UTC · lore

The selection of the branch to be pushed would be cleared when the remote was changed. This seems to be dependent on the fact that the selected content in the combobox was exported to the clipboard. It was only apparent when using the new ttk widget.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
Note: This patch was created inside the official git repo but should
apply cleanly to git-gui's master using 'git am -p2'
 git-gui/lib/transport.tcl |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Show changes to git-gui/lib/transport.tcl +3 −1
diff --git a/git-gui/lib/transport.tcl b/git-gui/lib/transport.tcl
index 49155c7..e4e1add 100644
--- a/git-gui/lib/transport.tcl
+++ b/git-gui/lib/transport.tcl
@@ -223,7 +223,9 @@ proc do_push_anywhere {} {
 			-value remote \
 			-variable push_urltype
 		if {$use_ttk} {
-			ttk::combobox $w.dest.remote_m -textvariable push_remote \
+			ttk::combobox $w.dest.remote_m -state readonly \
+				-exportselection false \
+				-textvariable push_remote \
 				-values $all_remotes
 		} else {
 			eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
-- 
1.7.4.34.gd2cb1

← back to recent threads