threads / patch / 26350

patchgitk: Preserve Entry class key bindings for SHA id

Subject: [PATCH] gitk: Preserve Entry class key bindings for SHA id

## tl;dr

One message between Jan 27, 2011 and Jan 27, 2011. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Kacper Kornet· Jan 27, 2011, 16:06 UTC · lore

If bind is specified for key without any modifier, then any combination of modifiers may be present in the event. So bind $e $ev "$escript; break" breaks some useful bindings from Entry class (for example Ctrl+k).

Signed-off-by: Kacper Kornet <kornet@camk.edu.pl>
---
 gitk |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
Show changes to gitk +5 −5
diff --git a/gitk b/gitk
index 9cbc09d..71eebb2 100755
--- a/gitk
+++ b/gitk
@@ -2389,6 +2389,10 @@ proc makewindow {} {
         }
     }
 
+    foreach e $entries {
+        bindtags $e [linsert [bindtags $e] 2 entrybind]
+    }
+
     bind .pwbottom <Configure> {resizecdetpanes %W %w}
     pack .ctop -fill both -expand 1
     bindall <1> {selcanvline %W %x %y}
@@ -2588,12 +2592,8 @@ proc scrollcanv {cscroll f0 f1} {
 proc bindkey {ev script} {
     global entries
     bind . $ev $script
-    set escript [bind Entry $ev]
-    if {$escript == {}} {
-	set escript [bind Entry <Key>]
-    }
     foreach e $entries {
-	bind $e $ev "$escript; break"
+	bind entrybind $ev "break"
     }
 }
 
-- 
1.7.3.5

-- 
  Kacper Kornet

← back to recent threads