# default update hook broken

2 messages from 2005-11-21 to 2005-11-21. Participants: Matthew Wilcox, Andreas Ericsson.
Thread: https://gitlist.dev/t/2632

## Matthew Wilcox, 2005-11-21 14:09

Subject: default update hook broken
Message-ID: <20051121140914.GB1598@parisc-linux.org>
URL: https://gitlist.dev/e/20051121140914.GB1598%40parisc-linux.org

```

There's two syntax errors and one good-netizen error in the hooks/update
file created when cloning Linus' linux-2.6.git repo.  I don't know
if that file is created fresh or if it gets pulled from Linus' tree.
Here's a patch to fix it

--- .git/hooks/update	2005-11-21 06:31:51.000000000 -0700
+++ /home/willy/replacement-update	2005-11-21 07:01:37.000000000 -0700
@@ -8,14 +8,14 @@
 # (2) make this file executable by "chmod +x update".
 #
 
-recipient="commit-list@mydomain.xz"
+recipient="commit-list@example.com"
 
 if expr "$2" : '0*$' >/dev/null
 then
 	echo "Created a new ref, with the following commits:"
 	git-rev-list --pretty "$3"
 else
-	$base=$(git-merge-base "$2" "$3")
+	base=$(git-merge-base "$2" "$3")
 	case "$base" in
 	"$2")
 		echo "New commits:"
@@ -24,8 +24,7 @@
 		echo "Rebased ref, commits from common ancestor:"
 		;;
 	esac
-fi
-git-rev-list --pretty "$3" "^$base"
+	git-rev-list --pretty "$3" "^$base"
 fi |
 mail -s "Changes to ref $1" "$recipient"
 exit 0

```

## Andreas Ericsson, 2005-11-21 18:08

Subject: Re: default update hook broken
Message-ID: <43820D0B.6000006@op5.se>
URL: https://gitlist.dev/e/43820D0B.6000006%40op5.se
In-Reply-To: <20051121140914.GB1598@parisc-linux.org>

```
Matthew Wilcox wrote:
> There's two syntax errors and one good-netizen error in the hooks/update
> file created when cloning Linus' linux-2.6.git repo.  I don't know
> if that file is created fresh or if it gets pulled from Linus' tree.
> Here's a patch to fix it
> 

Good thing I read new list entries before I send things. I did this 
exact same patch too. :)

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

```