# Re: [PATCH] Fix expected values of setup tests on Windows 12 messages from 2010-12-31 to 2011-01-11. Participants: Nguyen Thai Ngoc Duy, Johannes Sixt, Jonathan Nieder, Junio C Hamano. Thread: https://gitlist.dev/t/26167 ## Nguyen Thai Ngoc Duy, 2010-12-31 13:00 Subject: Re: [PATCH] Fix expected values of setup tests on Windows Message-ID: URL: https://gitlist.dev/e/AANLkTi%3DuCCfBFBpC%3D%2BV9RpaXRXiiPYp-tZXBxAVNB7%2Be%40mail.gmail.com In-Reply-To: <201012302205.13728.j6t@kdbg.org> ``` 2010/12/31 Johannes Sixt : > On Windows, bash stores absolute path names in shell variables in POSIX > format that begins with a slash, rather than in drive-letter format; such > a value is converted to the latter format when it is passed to a non-MSYS > program such as git. Hmm.. from test-lib.sh: TEST_DIRECTORY=$(pwd) test="trash directory.$(basename "$0" .sh)" TRASH_DIRECTORY="$TEST_DIRECTORY/$test" I'm just curious how these lines make $TRASH_DIRECTORY in POSIX format, while here=$(pwd) in your patch does not. Does bash auto convert value in TRASH_DIRECTORY="$TE..." line? -- Duy ``` ## Johannes Sixt, 2010-12-31 16:11 Subject: Re: [PATCH] Fix expected values of setup tests on Windows Message-ID: <201012311711.06989.j6t@kdbg.org> URL: https://gitlist.dev/e/201012311711.06989.j6t%40kdbg.org In-Reply-To: ``` On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote: > 2010/12/31 Johannes Sixt : > > On Windows, bash stores absolute path names in shell variables in POSIX > > format that begins with a slash, rather than in drive-letter format; such > > a value is converted to the latter format when it is passed to a non-MSYS > > program such as git. > > Hmm.. from test-lib.sh: > > TEST_DIRECTORY=$(pwd) > test="trash directory.$(basename "$0" .sh)" > TRASH_DIRECTORY="$TEST_DIRECTORY/$test" > > I'm just curious how these lines make $TRASH_DIRECTORY in POSIX format, > while > > here=$(pwd) > > in your patch does not. Does bash auto convert value in > TRASH_DIRECTORY="$TE..." line? No. When this line is executed: TEST_DIRECTORY=$(pwd) $(pwd) still has its default behavior to return the POSIX style path. pwd is redefined to pwd -W only later. I'm hesitant to redefine pwd earlier in test-lib.sh, though, because we would have to audit all uses of TEST_DIRECTORY for whether POSIX style paths or drive-letter paths are needed. -- Hannes ``` ## Jonathan Nieder, 2010-12-31 20:30 Subject: Re: [PATCH] Fix expected values of setup tests on Windows Message-ID: <20101231203019.GC5898@burratino> URL: https://gitlist.dev/e/20101231203019.GC5898%40burratino In-Reply-To: <201012311711.06989.j6t@kdbg.org> ``` Johannes Sixt wrote: > On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote: >> in your patch does not. Does bash auto convert value in >> TRASH_DIRECTORY="$TE..." line? > > No. When this line is executed: > > TEST_DIRECTORY=$(pwd) > > $(pwd) still has its default behavior to return the POSIX style path. pwd is > redefined to pwd -W only later. Would it make sense to change it to TEST_DIRECTORY=$PWD for clarity and robustness against code movement, then? ``` ## Johannes Sixt, 2010-12-31 22:21 Subject: Re: [PATCH] Fix expected values of setup tests on Windows Message-ID: <201012312321.31294.j6t@kdbg.org> URL: https://gitlist.dev/e/201012312321.31294.j6t%40kdbg.org In-Reply-To: <20101231203019.GC5898@burratino> ``` On Freitag, 31. Dezember 2010, Jonathan Nieder wrote: > Johannes Sixt wrote: > > On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote: > >> in your patch does not. Does bash auto convert value in > >> TRASH_DIRECTORY="$TE..." line? > > > > No. When this line is executed: > > > > TEST_DIRECTORY=$(pwd) > > > > $(pwd) still has its default behavior to return the POSIX style path. pwd > > is redefined to pwd -W only later. > > Would it make sense to change it to > > TEST_DIRECTORY=$PWD > > for clarity and robustness against code movement, then? Yes, that would make sense. -- Hannes ``` ## Nguyen Thai Ngoc Duy, 2011-01-01 03:46 Subject: Re: [PATCH] Fix expected values of setup tests on Windows Message-ID: URL: https://gitlist.dev/e/AANLkTinWdGDtxPk24OBQnJP8fdHW9gYNDn46YKRGTWoB%40mail.gmail.com In-Reply-To: <201012311711.06989.j6t@kdbg.org> ``` On Fri, Dec 31, 2010 at 11:11 PM, Johannes Sixt wrote: >> in your patch does not. Does bash auto convert value in >> TRASH_DIRECTORY="$TE..." line? > > No. When this line is executed: > > TEST_DIRECTORY=$(pwd) > > $(pwd) still has its default behavior to return the POSIX style path. pwd is > redefined to pwd -W only later. > > I'm hesitant to redefine pwd earlier in test-lib.sh, though, because we would > have to audit all uses of TEST_DIRECTORY for whether POSIX style paths or > drive-letter paths are needed. Ah I missed that. Thanks. Ack from me. -- Duy ``` ## Junio C Hamano, 2011-01-02 01:31 Subject: Re: [PATCH] Fix expected values of setup tests on Windows Message-ID: <7v62u8hz01.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v62u8hz01.fsf%40alter.siamese.dyndns.org In-Reply-To: <201012312321.31294.j6t@kdbg.org> ``` Johannes Sixt writes: > On Freitag, 31. Dezember 2010, Jonathan Nieder wrote: >> Johannes Sixt wrote: >> > On Freitag, 31. Dezember 2010, Nguyen Thai Ngoc Duy wrote: >> >> in your patch does not. Does bash auto convert value in >> >> TRASH_DIRECTORY="$TE..." line? >> > >> > No. When this line is executed: >> > >> > TEST_DIRECTORY=$(pwd) >> > >> > $(pwd) still has its default behavior to return the POSIX style path. pwd >> > is redefined to pwd -W only later. >> >> Would it make sense to change it to >> >> TEST_DIRECTORY=$PWD >> >> for clarity and robustness against code movement, then? > > Yes, that would make sense. It will be very much appreciated to add a few sentences to clarify this to "Do's and don'ts" section of t/README if you are re-rolling this. Thanks. ``` ## Johannes Sixt, 2011-01-11 07:44 Subject: [PATCH 2/2] t/README: hint about using $(pwd) rather than $PWD in tests Message-ID: <4D2C0A5E.7090708@viscovery.net> URL: https://gitlist.dev/e/4D2C0A5E.7090708%40viscovery.net In-Reply-To: <4D2C09D7.3070700@viscovery.net> ``` From: Johannes Sixt This adds just a "do it this way" instruction without a lot of explanation, because the details are too complex to be explained at this point. Signed-off-by: Johannes Sixt --- t/README | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/t/README b/t/README index 90718b4..f98ebb3 100644 --- a/t/README +++ b/t/README @@ -283,6 +283,12 @@ Do: Tests that are likely to smoke out future regressions are better than tests that just inflate the coverage metrics. + - When a test checks for an absolute path that a git command generated, + construct the expected value using $(pwd) rather than $PWD, + $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference on + Windows, where the shell (MSYS bash) mangles absolute path names. + For details, see the commit message of 4114156ae9. + Don't: - exit() within a