t0050-filesystem.sh unicode tests borked on dash shell

I noticed recently that the unicode tests, when run by the dash shell, have not been working as designed. (The tests *pass*, but they are *not* testing what was intended)

In order to demonstrate, I added an "false &&" line after the touch in test #8, so that (on Ubuntu):

    $ ./t0050-filesystem -i
    ok 1 - see what we expect
    ok 2 - detection of case insensitive filesystem during repo init
    ok 3 - detection of filesystem w/o symlink support during repo init
    ok 4 - setup case tests
    ok 5 - rename (case change)
    ok 6 - merge (case change)
    not ok 7 - add (with different case) # TODO known breakage
    not ok - 8 setup unicode normalization tests
    #	
    #	
    #	  test_create_repo unicode &&
    #	  cd unicode &&
    #	  touch "$aumlcdiar" &&
    #	false &&
    #	  git add "$aumlcdiar" &&
    #	  git commit -m initial &&
    #	  git tag initial &&
    #	  git checkout -b topic &&
    #	  git mv $aumlcdiar tmp &&
    #	  git mv tmp "$auml" &&
    #	  git commit -m rename &&
    #	  git checkout -f master
    #	
    #	
    $ ls trash\ directory.t0050-filesystem/unicode/
    \x61\xcc\x88

    $ bash t0050-filesystem -i
    ok 1 - see what we expect
    ok 2 - detection of case insensitive filesystem during repo init
    ok 3 - detection of filesystem w/o symlink support during repo init
    ok 4 - setup case tests
    ok 5 - rename (case change)
    ok 6 - merge (case change)
    not ok 7 - add (with different case) # TODO known breakage
    not ok - 8 setup unicode normalization tests
    #	
    #	
    #	  test_create_repo unicode &&
    #	  cd unicode &&
    #	  touch "$aumlcdiar" &&
    #	false &&
    #	  git add "$aumlcdiar" &&
    #	  git commit -m initial &&
    #	  git tag initial &&
    #	  git checkout -b topic &&
    #	  git mv $aumlcdiar tmp &&
    #	  git mv tmp "$auml" &&
    #	  git commit -m rename &&
    #	  git checkout -f master
    #	
    #	
    $ ls trash\ directory.t0050-filesystem/unicode/ | od -x
    0000000 cc61 0a88
    0000004

So bash works fine and I can avoid the problem by running the tests, thus:

    $ SHELL_PATH=/bin/bash make NO_SVN_TESTS=1 test

Since I have an older dash, I compiled dash from source (my dash git repo claims:

    $ git describe --tags
    v0.5.6-24-gb61ab0b

), but the result was exactly the same.

I afraid I don't have time to investigate this further at the moment ...

ATB, Ramsay Jones

Unlike bash and ksh, dash passes through hexadecimal \xcc escapes. So when run with dash, these tests *pass* (since '\xcc' is a perfectly reasonable filename) but they are not testing what was intended.

Use octal escapes instead, in the spirit of v1.6.1-rc1~55^2 (2008-11-09).

Reported-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Ramsay Jones wrote:

[...]

Good point. POSIX printf is not required to support \x escape sequences.

 t/t0050-filesystem.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Jonathan Nieder <jrnieder@gmail.com> writes:

Thanks.

Jonathan Nieder wrote:

Thanks everyone (Jonathan, Junio and Thomas) for the quick reply and fix! [I should have figured it out myself, but I just couldn't imagine printf not supporting hex escapes! :-P ]

ATB, Ramsay Jones

Ramsay Jones wrote:

The printf at the top evidently does not interpolate \xAA sequences. Since my 'man 1p printf' POSIX manpage only mandates \AAA octal sequences, maybe we should use that instead. Can you verify that the patch below works for you?

Judging from

  git grep '\\x[0-9a-f][0-9a-f]' t

this is the only instance of this problem, the rest are in Perl code.

--- 8< ---
Subject: t0050: replace \xAA by \AAA in printf

POSIX does not mandate the hex escape sequences, and thus dash's built-in printf does not expand them. Use octal escapes instead.

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

The built-in printf in dash seems to lack understanding of '\xXX'. It is tempting to patch it by using /usr/bin/printf but it is unclear how portable it would be.

 t/t0050-filesystem.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)