threads / discuss / 2611

What's in master tonight.

Subject: What's in master tonight.

## tl;dr

2 messages between Nov 20, 2005 and Nov 20, 2005.

replies: 1people: 2as markdown or json

Junio C Hamano· Nov 20, 2005, 08:40 UTC · lore

I've merged http updates (mostly code refactoring and cleanups) from Nick Hengeveld, config-set from Johannes Schindelin, and most of user-relative paths series from Andreas Ericsson. Cooking in proposed updates are the final part of user-relative paths series that changes git-daemon, git:// proxy support from Paul Collins, and repository format futureproofing from Martin Atukunda.

I'd like to do the next 1.0rc when at least the repository format futureproofing is ready. I personally can live without user-relative paths or git:// proxy, although both are probably nice to have. Here are the current status of these three topics.

repository format futureproofing::
	I think the current code can copy template/config that
	was prepared for wrong version of repository format
	without complaining.  It should barf and fail.
        I am unsure if the check in setup_git_repository() is
        the right thing to do.  It doesn't check when $GIT_DIR
        environment is set, which is wrong; receive-pack and
        upload-pack are run with this environment set to ".".
	Although majority of important core programs do check
	the repository format before doing any harmful
	operations, some higher level scripts should be told to
	do the checking upfront.  The config-set command by
	Johannes is probably handy for this purpose.
user relative paths::
	What's left from the master is the part that touches the
	git-daemon.  We need to be careful about being strict
	while validating the path against whitelist _after_
	DWIM, so the version in the proposed updates need to be
	checked to make sure it is safe.
proxy for git:// transport:
	I do not have any pending issues on this patch, and I
	think it is ready to go in when somebody, preferably
	other than the original author, says it is useful and
	does not break things.

The master branch is fairly ahead of the last 1.0rc as of this writing, and I'll be attending a wedding of a coworker, so there will not be maint updates this weekend.

Yaacov Akiba Slama· Nov 20, 2005, 14:28 UTC · re: Junio C Hamano · lore

Simple proxy test (was Re: What's in master tonight)

Junio C Hamano wrote:
Show 7 quoted lines
>proxy for git:// transport:
>
>	I do not have any pending issues on this patch, and I
>	think it is ready to go in when somebody, preferably
>	other than the original author, says it is useful and
>	does not break things.
>
I tested the proxy code from a place when the git:// port is blocked.
1) I made a ssh socks tunel (ssh -D 2080 a-remote-server).
2) I compiled connect.c from 
http://zippo.taiyo.co.jp/~gotoh/ssh/connect.html
3) I created a simple script called myproxy:
#!/bin/sh
/path/to/connect -S localhost:2080 $@
4) GIT_PROXY_COMMAND=/path/to/myproxy
cg-clone git://git.kernel.org/pub/scm/git/git.git git2 worked perfectly

4bis) % cat .git/config [core] gitproxy = /path/to/myproxy for kernel.org

cg update worked perfectly.
--yas

← back to recent threads