threads / patch / 26054

patch, 14 partst9142: Move call to start_httpd into the setup test

Subject: [PATCH 02/14] t9142: Move call to start_httpd into the setup test

## tl;dr

One message between Dec 14, 2010 and Dec 14, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Dec 14, 2010, 18:20 UTC · lore

In addition to being more consistent with the other calls to start_httpd in tests t9115-*.sh, t9118-*.sh and t9120-*.sh, this has the added benefit of making the test less noisy. (start_httpd writes "SVN_HTTPD_PORT is not defined!" on stderr.)

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 t/t9142-git-svn-shallow-clone.sh |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Show changes to t/t9142-git-svn-shallow-clone.sh +2 −3
diff --git a/t/t9142-git-svn-shallow-clone.sh b/t/t9142-git-svn-shallow-clone.sh
index 1236acc..e21ee5f 100755
--- a/t/t9142-git-svn-shallow-clone.sh
+++ b/t/t9142-git-svn-shallow-clone.sh
@@ -17,11 +17,10 @@ test_expect_success 'setup test repository' '
 		> foo &&
 		svn_cmd add foo &&
 		svn_cmd commit -m "add foo"
-	)
+	) &&
+	start_httpd
 '
 
-start_httpd
-
 test_expect_success 'clone trunk with "-r HEAD"' '
 	git svn clone -r HEAD "$svnrepo/trunk" g &&
 	( cd g && git rev-parse --symbolic --verify HEAD )
-- 
1.7.3

← back to recent threads