threads / patch / 26053

patch, 14 partsmisc test-suite patches

Subject: [PATCH 0/14] misc test-suite patches

## tl;dr

3 messages between Dec 14, 2010 and Dec 18, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ramsay Jones· Dec 14, 2010, 18:17 UTC · lore

Hi Junio,

I've had many of these test-suite related patches lying around for a while, so I'm passing these along now in the hope I can remove some old branches...

[PATCH 01/14] t3600-rm.sh: Don't pass a non-existent prereq to test #15 [PATCH 02/14] t9142: Move call to start_httpd into the setup test [PATCH 03/14] lib-git-svn.sh: Avoid setting web server variables unnecessarily [PATCH 04/14] lib-git-svn.sh: Add check for missing mod_dav_svn module [PATCH 05/14] lib-git-svn.sh: Add check for mis-configured web server variables [PATCH 06/14] t9501-*.sh: Fix a test failure on Cygwin [PATCH 07/14] t7800-difftool.sh: Fix a test failure on Cygwin [PATCH 08/14] help.c: Fix detection of custom merge strategy on cygwin [PATCH 09/14] t1301-*.sh: Fix the 'forced modes' test on cygwin [PATCH 10/14] t6038-*.sh: Pass the -b (--binary) option to sed on cygwin [PATCH 11/14] t3032-*.sh: Pass the -b (--binary) option to sed on cygwin [PATCH 12/14] t3032-*.sh: Do not strip CR from line-endings while grepping on MinGW [PATCH 13/14] t4135-*.sh: Skip the "backslash" tests on cygwin [PATCH 14/14] t{3032,6038}-*.sh: Allow SED_BIN_OPT to override the -b sed option

These patches don't really have too much in common, well 2-5 and 10-12 are somewhat related, other than fixing tests! (These were mostly done on Linux and Cygwin but, since I also test on MinGW, one or two are just for MinGW)

ATB, Ramsay Jones

Junio C Hamano· Dec 14, 2010, 19:44 UTC · re: Ramsay Jones · lore

Re: [PATCH 0/14] misc test-suite patches

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> I've had many of these test-suite related patches lying around for
> a while, so I'm passing these along now in the hope I can remove
> some old branches...

Thanks.

> [PATCH 08/14] help.c: Fix detection of custom merge strategy on cygwin
> [PATCH 09/14] t1301-*.sh: Fix the 'forced modes' test on cygwin

I sense that there is something fundamentally wrong with the tricky l/stat emulation set-up code there, but I lack an expertise to judge if these two patches is going in the right direction. Help from people savvier on Windows issues than I is very much appreciated.

Ramsay Jones· Dec 18, 2010, 20:08 UTC · re: Junio C Hamano · lore

Re: [PATCH 0/14] misc test-suite patches

Junio C Hamano wrote:

Show 7 quoted lines

>> [PATCH 08/14] help.c: Fix detection of custom merge strategy on cygwin
>> [PATCH 09/14] t1301-*.sh: Fix the 'forced modes' test on cygwin
> 
> I sense that there is something fundamentally wrong with the tricky l/stat
> emulation set-up code there, but I lack an expertise to judge if these two
> patches is going in the right direction.  Help from people savvier on
> Windows issues than I is very much appreciated.

Just as a matter of interest, since I put some extra effort into writing them, did you find the commit messages to be insufficient/unhelpful/confusing? What could I have done better?

ATB, Ramsay Jones