threads / patch / 26045

patchbuiltin/rm.c: Use ALLOG_GROW instead of alloc_nr and xrealloc.

Subject: [PATCH] builtin/rm.c: Use ALLOG_GROW instead of alloc_nr and xrealloc.

## tl;dr

2 messages between Dec 14, 2010 and Dec 14, 2010. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Thiago Farina· Dec 14, 2010, 01:37 UTC · lore
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 builtin/rm.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
Show changes to builtin/rm.c +1 −4
diff --git a/builtin/rm.c b/builtin/rm.c
index c7b7bb3..faeedfc 100644
--- a/builtin/rm.c
+++ b/builtin/rm.c
@@ -22,10 +22,7 @@ static struct {
 
 static void add_list(const char *name)
 {
-	if (list.nr >= list.alloc) {
-		list.alloc = alloc_nr(list.alloc);
-		list.name = xrealloc(list.name, list.alloc * sizeof(const char *));
-	}
+	ALLOC_GROW(list.name, list.nr + 1, list.alloc);
 	list.name[list.nr++] = name;
 }
 
-- 
1.7.3.2.343.g7d43d
Thiago Farina· Dec 14, 2010, 01:56 UTC · re: Thiago Farina · lore

Re: [PATCH] builtin/rm.c: Use ALLOG_GROW instead of alloc_nr and xrealloc.

On Mon, Dec 13, 2010 at 11:37 PM, Thiago Farina <tfransosi@gmail.com> wrote:
Show 21 quoted lines
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
>  builtin/rm.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/builtin/rm.c b/builtin/rm.c
> index c7b7bb3..faeedfc 100644
> --- a/builtin/rm.c
> +++ b/builtin/rm.c
> @@ -22,10 +22,7 @@ static struct {
>
>  static void add_list(const char *name)
>  {
> -       if (list.nr >= list.alloc) {
> -               list.alloc = alloc_nr(list.alloc);
> -               list.name = xrealloc(list.name, list.alloc * sizeof(const char *));
> -       }
> +       ALLOC_GROW(list.name, list.nr + 1, list.alloc);
>        list.name[list.nr++] = name;
>  }
>

Disregard this, as I made a typo in the subject. Sent another patch with the subject typo fixed. Thanks.

← back to recent threads