# [PATCH] t9010 fails when no svn is available

2 messages from 2010-12-09 to 2010-12-09. Participants: Junio C Hamano, Ramkumar Ramachandra.
Thread: https://gitlist.dev/t/26004

## Junio C Hamano, 2010-12-09 06:53

Subject: [PATCH] t9010 fails when no svn is available
Message-ID: <7vmxofh1x4.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vmxofh1x4.fsf%40alter.siamese.dyndns.org

```
Running test t9010 without svn currently errors out for no good reason.

The test uses "svnadmin" without checking if svn is available.  This was a
regression introduced by b0ad24b (t9010 (svn-fe): Eliminate dependency on
svn perl bindings, 2010-10-10) when it stopped including ./lib-git-svn.sh
that had the safety.

This should fix it.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t9010-svn-fe.sh |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
index fd851a4..faf9092 100755
--- a/t/t9010-svn-fe.sh
+++ b/t/t9010-svn-fe.sh
@@ -4,6 +4,12 @@ test_description='check svn dumpfile importer'
 
 . ./test-lib.sh
 
+if ! svnadmin -h >/dev/null 2>&1
+then
+	skip_all='skipping svn-fe tests, svn not available'
+	test_done
+fi
+
 svnconf=$PWD/svnconf
 export svnconf
 

```

## Ramkumar Ramachandra, 2010-12-09 08:39

Subject: Re: [PATCH] t9010 fails when no svn is available
Message-ID: <20101209083938.GC21446@kytes>
URL: https://gitlist.dev/e/20101209083938.GC21446%40kytes
In-Reply-To: <7vmxofh1x4.fsf@alter.siamese.dyndns.org>

```
Junio C Hamano writes:
> Running test t9010 without svn currently errors out for no good reason.
> 
> The test uses "svnadmin" without checking if svn is available.  This was a
> regression introduced by b0ad24b (t9010 (svn-fe): Eliminate dependency on
> svn perl bindings, 2010-10-10) when it stopped including ./lib-git-svn.sh
> that had the safety.
> 
> This should fix it.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Right. Thanks for catching this.

-- Ram

```