threads / patch / 25964

patch, 14 partscat-file.c: Initialise variable to suppress msvc warning

Subject: [PATCH 11/14] cat-file.c: Initialise variable to suppress msvc warning

## tl;dr

One message between Dec 4, 2010 and Dec 4, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Ramsay Jones· Dec 4, 2010, 19:10 UTC · lore

The msvc compiler thinks that a variable could be used while uninitialised and issues the following warning:

    ...\git\builtin\cat-file.c(171) : warning C4700: uninitialized \
        local variable 'contents' used

In order to suppress the warning, we simply initialise the contents pointer variable to NULL.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 builtin/cat-file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin/cat-file.c +1 −1
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index 94632db..472f3ad 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -168,7 +168,7 @@ static int batch_one_object(const char *obj_name, int print_contents)
 	unsigned char sha1[20];
 	enum object_type type = 0;
 	unsigned long size;
-	void *contents = contents;
+	void *contents = NULL;
 
 	if (!obj_name)
 	   return 1;
-- 
1.7.3

← back to recent threads