[PATCH 08/14] submodule.c: Initialise variables to suppress msvc warnings

Ramsay Jones· Dec 4, 2010, 19:07 UTC · lore

The msvc compiler thinks that two variables could be used while uninitialised and issues the following warnings:

    ...\git\submodule.c(147) : warning C4700: uninitialized local \
        variable 'left' used
    ...\git\submodule.c(147) : warning C4700: uninitialized local \
        variable 'right' used

In order to suppress the warnings, we simply initialise the pointer variables to NULL.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 submodule.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to submodule.c +1 −1

diff --git a/submodule.c b/submodule.c
index 91a4758..eef498a 100644
--- a/submodule.c
+++ b/submodule.c
@@ -144,7 +144,7 @@ void show_submodule_summary(FILE *f, const char *path,
 		const char *del, const char *add, const char *reset)
 {
 	struct rev_info rev;
-	struct commit *commit, *left = left, *right = right;
+	struct commit *commit, *left = NULL, *right = NULL;
 	struct commit_list *merge_bases, *list;
 	const char *message = NULL;
 	struct strbuf sb = STRBUF_INIT;

-- 
1.7.3

patch, 14 partssubmodule.c: Initialise variables to suppress msvc warnings