# [PATCH 0/14] misc msvc patches

1 messages from 2010-12-04 to 2010-12-04. Participants: Ramsay Jones.
Thread: https://gitlist.dev/t/25953

## Ramsay Jones, 2010-12-04 18:49

Subject: [PATCH 0/14] misc msvc patches
Message-ID: <4CFA8D4D.2020500@ramsay1.demon.co.uk>
URL: https://gitlist.dev/e/4CFA8D4D.2020500%40ramsay1.demon.co.uk

```
Hi Junio,

The msvc build of git.git is currently broken; these patches fix
the build and suppress most of the *many* compiler warnings.
[These patches are based on master @ 94fdb6f from 2 days ago]

[PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
[PATCH 02/14] msvc: git-daemon.exe: Fix linker "unresolved externals" error
[PATCH 03/14] msvc: Fix build by adding missing INTMAX_MAX define

These patches actually fix the build. Note that I haven't actually tested
git-daemon.exe, but it should behave exactly the same as the MinGW build
(famous last words).

[PATCH 04/14] msvc: Fix macro redefinition warnings

Prior to this patch, the msvc build spews 1184 warnings. After this patch,
the warning count is down to 176! :-P

[PATCH 05/14] run-command.c: Initialise variable to suppress msvc warnings
[PATCH 06/14] match-trees.c: Initialise variables to suppress msvc warnings
[PATCH 07/14] fast-import.c: Initialise variables to suppress msvc warnings
[PATCH 08/14] submodule.c: Initialise variables to suppress msvc warnings
[PATCH 09/14] merge-recursive.c: Initialise variable to suppress msvc warning
[PATCH 10/14] fast-export.c: Initialise variable to suppress msvc warning
[PATCH 11/14] cat-file.c: Initialise variable to suppress msvc warning
[PATCH 12/14] rev-list.c: Initialise variables to suppress msvc warnings
[PATCH 13/14] transport.c: Initialise variable to suppress msvc warning
[PATCH 14/14] wt-status.c: Initialise variable to suppress msvc warning

These patches were originally a single patch, since they all implement the
same fix, and could be squashed back into a single commit.  However, I
decided to split it up by file to make it easier to review. Note that the
warnings here are issued by the linker, since we have requested link-time
code generation, which explains why the one-liner in patch 5 fixes 26
warnings (start_command() is linked into 26 executables). These patches
reduce the warning count to 126.

[The remaining 126 warnings are all very similar, see an up-coming RFC series]

ATB,
Ramsay Jones

```