# [PATCH] commit: Remove backward goto in read_craft_line() 1 messages from 2010-12-01 to 2010-12-01. Participants: Ralf Thielow. Thread: https://gitlist.dev/t/25902 ## Ralf Thielow, 2010-12-01 19:59 Subject: [PATCH] commit: Remove backward goto in read_craft_line() Message-ID: <1291233546-4962-1-git-send-email-ralf.thielow@googlemail.com> URL: https://gitlist.dev/e/1291233546-4962-1-git-send-email-ralf.thielow%40googlemail.com ``` Bad graft data is noticed in several places in read_graft_line and in each case we go back to the first site of detection. Move the error handling to the end of the function for better readability. Signed-off-by: Ralf Thielow --- commit.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/commit.c b/commit.c index 0094ec1..642ee34 100644 --- a/commit.c +++ b/commit.c @@ -137,12 +137,8 @@ struct commit_graft *read_graft_line(char *buf, int len) buf[--len] = '\0'; if (buf[0] == '#' || buf[0] == '\0') return NULL; - if ((len + 1) % 41) { - bad_graft_data: - error("bad graft data: %s", buf); - free(graft); - return NULL; - } + if ((len + 1) % 41) + goto bad_graft_data; i = (len + 1) / 41 - 1; graft = xmalloc(sizeof(*graft) + 20 * i); graft->nr_parent = i; @@ -155,6 +151,10 @@ struct commit_graft *read_graft_line(char *buf, int len) goto bad_graft_data; } return graft; + bad_graft_data: + error("bad graft data: %s", buf); + free(graft); + return NULL; } static int read_graft_file(const char *graft_file) -- 1.7.1 ```