# Patchbombing or not, that is the question 6 messages from 2010-11-27 to 2010-11-27. Participants: Giuseppe Bilotta, Jonathan Nieder, Thiago Farina. Thread: https://gitlist.dev/t/25854 ## Giuseppe Bilotta, 2010-11-27 17:18 Subject: Patchbombing or not, that is the question Message-ID: URL: https://gitlist.dev/e/AANLkTi%3DC4opog2SfU9R_%3DdSOGY_5%2B0WYtFL8BNqcOwUw%40mail.gmail.com ``` Hello all, I prepared a bunch of patches to add support to some other browsers to git-web--browse (opera, seamonkey, elinks). Currently I did one patch per browser. Should I squash them all together? (The series will also contain some other patches that will stay separate.) -- Giuseppe "Oblomov" Bilotta ``` ## Jonathan Nieder, 2010-11-27 17:27 Subject: Re: Patchbombing or not, that is the question Message-ID: <20101127172757.GA1858@burratino> URL: https://gitlist.dev/e/20101127172757.GA1858%40burratino In-Reply-To: ``` Giuseppe Bilotta wrote: > I prepared a bunch of patches to add support to some other browsers to > git-web--browse (opera, seamonkey, elinks). Currently I did one patch > per browser. Should I squash them all together? Yeah, I'd squash them. (But I think either way would be fine.) Could you support [browser "chromium-browser"] cmd=chromium-browser while at it? :) ``` ## Thiago Farina, 2010-11-27 17:40 Subject: Re: Patchbombing or not, that is the question Message-ID: URL: https://gitlist.dev/e/AANLkTimKdwrsYQHGL%3DKaoQEmv3FLJzS%2BM%3D5xdQi%2BA5Ny%40mail.gmail.com In-Reply-To: <20101127172757.GA1858@burratino> ``` On Sat, Nov 27, 2010 at 3:27 PM, Jonathan Nieder wrote: > Giuseppe Bilotta wrote: > >> I prepared a bunch of patches to add support to some other browsers to >> git-web--browse (opera, seamonkey, elinks). Currently I did one patch >> per browser. Should I squash them all together? > > Yeah, I'd squash them.  (But I think either way would be fine.) > > Could you support > >        [browser "chromium-browser"] >                cmd=chromium-browser > Yeah, that would be great! ``` ## Giuseppe Bilotta, 2010-11-27 18:13 Subject: Re: Patchbombing or not, that is the question Message-ID: URL: https://gitlist.dev/e/AANLkTik2WXj3kN2859_iSLQWarkR9ugJQiL2TwiNj109%40mail.gmail.com In-Reply-To: ``` On Sat, Nov 27, 2010 at 6:40 PM, Thiago Farina wrote: > On Sat, Nov 27, 2010 at 3:27 PM, Jonathan Nieder wrote: >> Giuseppe Bilotta wrote: >> >>> I prepared a bunch of patches to add support to some other browsers to >>> git-web--browse (opera, seamonkey, elinks). Currently I did one patch >>> per browser. Should I squash them all together? >> >> Yeah, I'd squash them.  (But I think either way would be fine.) >> >> Could you support >> >>        [browser "chromium-browser"] >>                cmd=chromium-browser >> > Yeah, that would be great! Actually I think that in this case the 'chromimu' configuration should look for chromium-browser if chromium is not found. -- Giuseppe "Oblomov" Bilotta ``` ## Jonathan Nieder, 2010-11-27 18:34 Subject: Re: Patchbombing or not, that is the question Message-ID: <20101127183421.GA2131@burratino> URL: https://gitlist.dev/e/20101127183421.GA2131%40burratino In-Reply-To: ``` Giuseppe Bilotta wrote: > Actually I think that in this case the 'chromimu' configuration should > look for chromium-browser if chromium is not found. Even better might be to go straight for chromium-browser, to avoid confusion with ancient versions of chromium-bsu. Anyway, I hadn't noticed the new support for chromium. Thanks for pointing it out. ``` ## Giuseppe Bilotta, 2010-11-27 18:39 Subject: Re: Patchbombing or not, that is the question Message-ID: URL: https://gitlist.dev/e/AANLkTinGNURJVdnQjw5BvR1tkoOdCRdgY2poYb8PFH2R%40mail.gmail.com In-Reply-To: <20101127183421.GA2131@burratino> ``` On Sat, Nov 27, 2010 at 7:34 PM, Jonathan Nieder wrote: > Giuseppe Bilotta wrote: > >> Actually I think that in this case the 'chromimu' configuration should >> look for chromium-browser if chromium is not found. > > Even better might be to go straight for chromium-browser, to avoid > confusion with ancient versions of chromium-bsu. More precisely, we should look for chromium-browser first, and if not found then use chromium. The fall-back to chromium is, I think, needed because I suspect the binary was renamed in Debian only. Can somebody with some other distribution confirm that chromium is called chromium there? -- Giuseppe "Oblomov" Bilotta ```