threads / patch / 25797

patcht9010 (svn-fe): Eliminate dependency on svn perl bindings

Subject: [PATCH jn/svn-fe] t9010 (svn-fe): Eliminate dependency on svn perl bindings

## tl;dr

One message between Nov 20, 2010 and Nov 20, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jonathan Nieder· Nov 20, 2010, 22:31 UTC · lore
From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sun Oct 10 22:00:40 2010 -0500

Running test t9010 without the SVN:: perl modules currently errors out, for no good reason. We can make these tests easier to read and run by not using the perl libsvn bindings and instead duplicating only the relevant code from lib-git-svn.sh.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
A patch from Ram from a while ago.  It's still a good idea; sorry
about the delay.

Patch is against the old svn-fe branch (cd9a7b57) but should apply just as well to more recent versions.

 t/t9010-svn-fe.sh |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)
Show changes to t/t9010-svn-fe.sh +12 −2
diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
index a713dfc..fd851a4 100755
--- a/t/t9010-svn-fe.sh
+++ b/t/t9010-svn-fe.sh
@@ -2,9 +2,19 @@
 
 test_description='check svn dumpfile importer'
 
-. ./lib-git-svn.sh
+. ./test-lib.sh
 
-test_dump() {
+svnconf=$PWD/svnconf
+export svnconf
+
+svn_cmd () {
+	subcommand=$1 &&
+	shift &&
+	mkdir -p "$svnconf" &&
+	svn "$subcommand" --config-dir "$svnconf" "$@"
+}
+
+test_dump () {
 	label=$1
 	dump=$2
 	test_expect_success "$dump" '
-- 
1.7.2.3

← back to recent threads