# [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names 13 messages from 2010-11-20 to 2011-02-06. Participants: Joe Perches, Andreas Schwab, Pete Harlan, Junio C Hamano. Thread: https://gitlist.dev/t/25795 ## Joe Perches, 2010-11-20 17:06 Subject: [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <1290272809.27951.30.camel@Joe-Laptop> URL: https://gitlist.dev/e/1290272809.27951.30.camel%40Joe-Laptop ``` If an email address in the "to:" list is in the style "First Last ", ie: not just a bare address like "email@domain.tld", and the same named entry style exists in the "cc:" list, the current logic will not remove the entry from the "cc:" list. Add logic to better deduplicate the "cc:" list by also matching the email address with angle brackets. Signed-off-by: Joe Perches --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index f68ed5a..1ae5fbf 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -960,7 +960,7 @@ sub maildomain { sub send_message { my @recipients = unique_email_list(@to); @cc = (grep { my $cc = extract_valid_address($_); - not grep { $cc eq $_ } @recipients + not grep { $cc eq $_ || $_ =~ /<${cc}>$/ } @recipients } map { sanitize_address($_) } @cc); ``` ## Andreas Schwab, 2010-11-20 20:15 Subject: Re: [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: URL: https://gitlist.dev/e/m2mxp3zr88.fsf%40igel.home In-Reply-To: <1290272809.27951.30.camel@Joe-Laptop> ``` Joe Perches writes: > diff --git a/git-send-email.perl b/git-send-email.perl > index f68ed5a..1ae5fbf 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -960,7 +960,7 @@ sub maildomain { > sub send_message { > my @recipients = unique_email_list(@to); > @cc = (grep { my $cc = extract_valid_address($_); > - not grep { $cc eq $_ } @recipients > + not grep { $cc eq $_ || $_ =~ /<${cc}>$/ } @recipients /<\Q${cc}\E>$/ Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ``` ## Joe Perches, 2010-11-20 21:01 Subject: Re: [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <1290286877.31117.15.camel@Joe-Laptop> URL: https://gitlist.dev/e/1290286877.31117.15.camel%40Joe-Laptop In-Reply-To: ``` On Sat, 2010-11-20 at 21:15 +0100, Andreas Schwab wrote: > Joe Perches writes: > > diff --git a/git-send-email.perl b/git-send-email.perl > > index f68ed5a..1ae5fbf 100755 > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -960,7 +960,7 @@ sub maildomain { > > sub send_message { > > my @recipients = unique_email_list(@to); > > @cc = (grep { my $cc = extract_valid_address($_); > > - not grep { $cc eq $_ } @recipients > > + not grep { $cc eq $_ || $_ =~ /<${cc}>$/ } @recipients > /<\Q${cc}\E>$/ Why are \Q and \E useful here? extract_valid_address provides an unadorned email address. I've now tested with and without, both seem to work properly. ``` ## Pete Harlan, 2010-11-20 22:47 Subject: Re: [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <4CE84FF3.2070906@pcharlan.com> URL: https://gitlist.dev/e/4CE84FF3.2070906%40pcharlan.com In-Reply-To: <1290286877.31117.15.camel@Joe-Laptop> ``` On 11/20/2010 01:01 PM, Joe Perches wrote: > On Sat, 2010-11-20 at 21:15 +0100, Andreas Schwab wrote: >> Joe Perches writes: >> > diff --git a/git-send-email.perl b/git-send-email.perl >> > index f68ed5a..1ae5fbf 100755 >> > --- a/git-send-email.perl >> > +++ b/git-send-email.perl >> > @@ -960,7 +960,7 @@ sub maildomain { >> > sub send_message { >> > my @recipients = unique_email_list(@to); >> > @cc = (grep { my $cc = extract_valid_address($_); >> > - not grep { $cc eq $_ } @recipients >> > + not grep { $cc eq $_ || $_ =~ /<${cc}>$/ } @recipients >> /<\Q${cc}\E>$/ > > Why are \Q and \E useful here? > extract_valid_address provides an unadorned email address. > I've now tested with and without, both seem to work properly. Because email addresses can contain characters (e.g., '+') that you don't want the regular expression to treat specially. ``` ## Andreas Schwab, 2010-11-20 22:57 Subject: Re: [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: URL: https://gitlist.dev/e/m2eiafzjqg.fsf%40igel.home In-Reply-To: <1290286877.31117.15.camel@Joe-Laptop> ``` Joe Perches writes: > extract_valid_address provides an unadorned email address. An email address is not a regexp. Thus it may not match itself. > I've now tested with and without, both seem to work properly. Did you test with all possible email addresses? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ``` ## Joe Perches, 2010-11-20 23:00 Subject: Re: [PATCH] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <1290294012.31117.34.camel@Joe-Laptop> URL: https://gitlist.dev/e/1290294012.31117.34.camel%40Joe-Laptop In-Reply-To: ``` On Sat, 2010-11-20 at 23:57 +0100, Andreas Schwab wrote: > Joe Perches writes: > > extract_valid_address provides an unadorned email address. > An email address is not a regexp. Thus it may not match itself. > > I've now tested with and without, both seem to work properly. > Did you test with all possible email addresses? :) That'd take forever... ``` ## Joe Perches, 2010-11-20 23:06 Subject: [PATCH V2] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <1290294365.31117.40.camel@Joe-Laptop> URL: https://gitlist.dev/e/1290294365.31117.40.camel%40Joe-Laptop In-Reply-To: <4CE84FF3.2070906@pcharlan.com> ``` If an email address in the "to:" list is in the style "First Last ", ie: not just a bare address like "email@domain.tld", and the same named entry style exists in the "cc:" list, the current logic will not remove the entry from the "cc:" list. Add logic to better deduplicate the "cc:" list by also matching the email address with angle brackets. Signed-off-by: Joe Perches --- V2: Added quote escaping suggested by Andreas Schwab git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-send-email.perl b/git-send-email.perl index f68ed5a..1ae5fbf 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -960,7 +960,7 @@ sub maildomain { sub send_message { my @recipients = unique_email_list(@to); @cc = (grep { my $cc = extract_valid_address($_); - not grep { $cc eq $_ } @recipients + not grep { $cc eq $_ || $_ =~ /<\Q${cc}\E>$/ } @recipients } map { sanitize_address($_) } @cc); ``` ## Junio C Hamano, 2010-11-26 18:34 Subject: Re: [PATCH V2] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <7vmxowq6gz.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vmxowq6gz.fsf%40alter.siamese.dyndns.org In-Reply-To: <1290294365.31117.40.camel@Joe-Laptop> ``` Joe Perches writes: > If an email address in the "to:" list is in the style > "First Last ", ie: not just a bare > address like "email@domain.tld", and the same named > entry style exists in the "cc:" list, the current > logic will not remove the entry from the "cc:" list. > > Add logic to better deduplicate the "cc:" list by also > matching the email address with angle brackets. Thanks; this is an improvement from the current behaviour. We do cull duplicates if you have the same address listed on @cc twice, but we don't do the similar culling between To:/Cc: headers. I wonder if we should remove addresses from To: and Cc: if the same address appears in @bcclist, by the way, but that is a separate topic. Thanks. ``` ## Joe Perches, 2010-11-26 21:34 Subject: Re: [PATCH V2] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <1290807268.11971.310.camel@Joe-Laptop> URL: https://gitlist.dev/e/1290807268.11971.310.camel%40Joe-Laptop In-Reply-To: <7vmxowq6gz.fsf@alter.siamese.dyndns.org> ``` On Fri, 2010-11-26 at 10:34 -0800, Junio C Hamano wrote: > I wonder if we should remove addresses from To: and Cc: if the same > address appears in @bcclist, by the way, but that is a separate topic. Most likely it should be culled from the bcclist. ``` ## Junio C Hamano, 2010-11-27 00:25 Subject: Re: [PATCH V2] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <7vk4jzpq8h.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk4jzpq8h.fsf%40alter.siamese.dyndns.org In-Reply-To: <1290807268.11971.310.camel@Joe-Laptop> ``` Joe Perches writes: > On Fri, 2010-11-26 at 10:34 -0800, Junio C Hamano wrote: >> I wonder if we should remove addresses from To: and Cc: if the same >> address appears in @bcclist, by the way, but that is a separate topic. > > Most likely it should be culled from the bcclist. That means that the current behaviour is Ok, no? We do make the "RCPT TO" list of addresses we feed to smtp unique after concatenating To/Cc/Bcc, if I am not mistaken. ``` ## Joe Perches, 2010-11-27 00:39 Subject: Re: [PATCH V2] git-send-email.perl: Deduplicate "to:" and "cc:" entries with names Message-ID: <1290818342.11971.325.camel@Joe-Laptop> URL: https://gitlist.dev/e/1290818342.11971.325.camel%40Joe-Laptop In-Reply-To: <7vk4jzpq8h.fsf@alter.siamese.dyndns.org> ``` On Fri, 2010-11-26 at 16:25 -0800, Junio C Hamano wrote: > Joe Perches writes: > > On Fri, 2010-11-26 at 10:34 -0800, Junio C Hamano wrote: > >> I wonder if we should remove addresses from To: and Cc: if the same > >> address appears in @bcclist, by the way, but that is a separate topic. > > Most likely it should be culled from the bcclist. > That means that the current behaviour is Ok, no? We do make the "RCPT TO" > list of addresses we feed to smtp unique after concatenating To/Cc/Bcc, if > I am not mistaken. I believe it's correct as is. ``` ## Joe Perches, 2011-02-05 23:40 Subject: [PATCH] git-send-email.perl: Add --suppress-to Message-ID: <1296949208.4133.66.camel@Joe-Laptop> URL: https://gitlist.dev/e/1296949208.4133.66.camel%40Joe-Laptop In-Reply-To: <7vk4jzpq8h.fsf@alter.siamese.dyndns.org> ``` Add an equivalent command line option to suppress-cc. Signed-off-by: Joe Perches --- Documentation/git-send-email.txt | 17 +++++++++++++++++ git-send-email.perl | 33 +++++++++++++++++++++++++++++++-- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 7ec9dab..69e03e8 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -232,6 +232,23 @@ Automating cc list. Default is the value of 'sendemail.signedoffbycc' configuration value; if that is unspecified, default to --signed-off-by-cc. +--suppress-to=:: + Specify an additional category of recipients to suppress the + auto-to of: ++ +-- +- 'author' will avoid including the patch author +- 'self' will avoid including the sender +- 'tocmd' will avoid running the --to-cmd +- 'bodyto' will avoid including anyone mentioned in To lines in the + patch body (commit message) except for self (use 'self' for that) +- 'all' will suppress all auto to values. +-- ++ +Default is the value of 'sendemail.suppressto' configuration value; if +that is unspecified, default to 'self' if --suppress-from is +specified. + --suppress-cc=:: Specify an additional category of recipients to suppress the auto-cc of: diff --git a/git-send-email.perl b/git-send-email.perl index 76565de..0365c29 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -74,6 +74,7 @@ git send-email [options] Automating: --identity * Use the sendemail. options. --to-cmd * Email To: via ` \$patch_path` + --suppress-to * author, self, tocmd, bodyto, all. --cc-cmd * Email Cc: via ` \$patch_path` --suppress-cc * author, self, sob, cc, cccmd, body, bodycc, all. --[no-]signed-off-by-cc * Send to Signed-off-by: addresses. Default on. @@ -196,6 +197,7 @@ my ($smtp_server, $smtp_server_port, @smtp_server_options); my ($smtp_authuser, $smtp_encryption); my ($identity, $aliasfiletype, @alias_files, $smtp_domain); my ($validate, $confirm); +my (@suppress_to); my (@suppress_cc); my ($auto_8bit_encoding); @@ -226,6 +228,7 @@ my %config_settings = ( "aliasfiletype" => \$aliasfiletype, "bcc" => \@bcclist, "aliasesfile" => \@alias_files, + "suppressto" => \@suppress_to, "suppresscc" => \@suppress_cc, "envelopesender" => \$envelope_sender, "multiedit" => \$multiedit, @@ -301,6 +304,7 @@ my $rc = GetOptions("sender|from=s" => \$sender, "quiet" => \$quiet, "cc-cmd=s" => \$cc_cmd, "suppress-from!" => \$suppress_from, + "suppress-to=s" => \@suppress_to, "suppress-cc=s" => \@suppress_cc, "signed-off-cc|signed-off-by-cc!" => \$signed_off_by_cc, "confirm=s" => \$confirm, @@ -369,6 +373,24 @@ foreach my $setting (values %config_bool_settings) { # 'default' encryption is none -- this only prevents a warning $smtp_encryption = '' unless (defined $smtp_encryption); +# Set TO suppressions +my(%suppress_to); +if (@suppress_to) { + foreach my $entry (@suppress_to) { + die "Unknown --suppress-to field: '$entry'\n" + unless $entry =~ /^(?:all|author|self|tocmd|bodyto)$/; + $suppress_to{$entry} = 1; + } +} + +if ($suppress_to{'all'}) { + foreach my $entry (qw (author self tocmd bodyto)) { + $suppress_to{$entry} = 1; + } + delete $suppress_to{'all'}; +} +$suppress_to{'self'} = $suppress_from if defined $suppress_from; + # Set CC suppressions my(%suppress_cc); if (@suppress_cc) { @@ -407,7 +429,11 @@ die "Unknown --confirm setting: '$confirm'\n" # Debugging, print out the suppressions. if (0) { - print "suppressions:\n"; + print "To suppressions:\n"; + foreach my $entry (keys %suppress_to) { + printf " %-5s -> $suppress_to{$entry}\n", $entry; + } + print "Cc suppressions:\n"; foreach my $entry (keys %suppress_cc) { printf " %-5s -> $suppress_cc{$entry}\n", $entry; } @@ -1201,6 +1227,9 @@ foreach my $t (@files) { } elsif (/^To:\s+(.*)$/) { foreach my $addr (parse_address_line($1)) { + + next if $suppress_to{'author'}; + next if $suppress_to{'self'} and $author eq $sender; printf("(mbox) Adding to: %s from line '%s'\n", $addr, $_) unless $quiet; push @to, sanitize_address($addr); @@ -1269,7 +1298,7 @@ foreach my $t (@files) { close $fh; push @to, recipients_cmd("to-cmd", "to", $to_cmd, $t) - if defined $to_cmd; + if defined $to_cmd && !$suppress_to{'tocmd'}; push @cc, recipients_cmd("cc-cmd", "cc", $cc_cmd, $t) if defined $cc_cmd && !$suppress_cc{'cccmd'}; ``` ## Junio C Hamano, 2011-02-06 20:28 Subject: Re: [PATCH] git-send-email.perl: Add --suppress-to Message-ID: <7vr5bkx606.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vr5bkx606.fsf%40alter.siamese.dyndns.org In-Reply-To: <1296949208.4133.66.camel@Joe-Laptop> ``` Joe Perches writes: > +- 'author' will avoid including the patch author > +- 'self' will avoid including the sender > +- 'tocmd' will avoid running the --to-cmd > +- 'bodyto' will avoid including anyone mentioned in To lines in the > + patch body (commit message) except for self (use 'self' for that) > +- 'all' will suppress all auto to values. Is there a definition of what an "auto to value" is somewhere? "auto cc values" was sort of understandable as there is no word "cc" (other than 1/1000 litre ;-) and what it meant was guessable from context, but it took me a few seconds to realize you meant "To:" with this. > +-- > ++ > +Default is the value of 'sendemail.suppressto' configuration value; if > +that is unspecified, default to 'self' if --suppress-from is > +specified. > + > --suppress-cc=:: > Specify an additional category of recipients to suppress the > auto-cc of: Hmmm, from a cursory look I don't see how bodyto is handled and where. > @@ -1201,6 +1227,9 @@ foreach my $t (@files) { > } > elsif (/^To:\s+(.*)$/) { > foreach my $addr (parse_address_line($1)) { > + > + next if $suppress_to{'author'}; Is "To: somebody" in the output guaranteed to name the author and nobody else? > + next if $suppress_to{'self'} and $author eq $sender; > printf("(mbox) Adding to: %s from line '%s'\n", > $addr, $_) unless $quiet; > push @to, sanitize_address($addr); > @@ -1269,7 +1298,7 @@ foreach my $t (@files) { > close $fh; > > push @to, recipients_cmd("to-cmd", "to", $to_cmd, $t) > - if defined $to_cmd; > + if defined $to_cmd && !$suppress_to{'tocmd'}; > push @cc, recipients_cmd("cc-cmd", "cc", $cc_cmd, $t) > if defined $cc_cmd && !$suppress_cc{'cccmd'}; I think it is about time to make this a bit more readable by explicitly using if statement, not statement modifiers. ```