# [PATCH] clean: remove redundant variable baselen 1 messages from 2010-11-15 to 2010-11-15. Participants: Nguyễn Thái Ngọc Duy. Thread: https://gitlist.dev/t/25748 ## Nguyễn Thái Ngọc Duy, 2010-11-15 06:42 Subject: [PATCH] clean: remove redundant variable baselen Message-ID: <1289803364-16452-1-git-send-email-pclouds@gmail.com> URL: https://gitlist.dev/e/1289803364-16452-1-git-send-email-pclouds%40gmail.com ``` baselen used to be the result of common_prefix() when it was made builtin. Since 1d8842d (Add 'fill_directory()' helper function for directory traversal - 2009-05-14), its value will always be zero. Remove it because it's no longer variable. Signed-off-by: Nguyễn Thái Ngọc Duy --- Or bring common_prefix() back. I'm not sure if it's worth it. builtin/clean.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/clean.c b/builtin/clean.c index c8798f5..5200cca 100644 --- a/builtin/clean.c +++ b/builtin/clean.c @@ -38,7 +38,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix) { int i; int show_only = 0, remove_directories = 0, quiet = 0, ignored = 0; - int ignored_only = 0, baselen = 0, config_set = 0, errors = 0; + int ignored_only = 0, config_set = 0, errors = 0; int rm_flags = REMOVE_DIR_KEEP_NESTED_GIT; struct strbuf directory = STRBUF_INIT; struct dir_struct dir; @@ -138,7 +138,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix) if (pathspec) { memset(seen, 0, argc > 0 ? argc : 1); matches = match_pathspec(pathspec, ent->name, len, - baselen, seen); + 0, seen); } if (S_ISDIR(st.st_mode)) { -- 1.7.3.2.210.g045198 ```