# [PATCH] Fix username and password extraction from HTTP URLs 2 messages from 2010-11-12 to 2010-11-13. Participants: Gabriel Corona, Sverre Rabbelier. Thread: https://gitlist.dev/t/25729 ## Gabriel Corona, 2010-11-12 23:20 Subject: [PATCH] Fix username and password extraction from HTTP URLs Message-ID: <1289604025-6406-1-git-send-email-gabriel.corona@enst-bretagne.fr> URL: https://gitlist.dev/e/1289604025-6406-1-git-send-email-gabriel.corona%40enst-bretagne.fr ``` Change the authentification initialisation to percent-decode username and password for HTTP URLs. Signed-off-by: Gabriel Corona --- http.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/http.c b/http.c index 0a5011f..c9393a8 100644 --- a/http.c +++ b/http.c @@ -2,6 +2,7 @@ #include "pack.h" #include "sideband.h" #include "run-command.h" +#include "url.h" int data_received; int active_requests; @@ -297,7 +298,7 @@ static CURL *get_curl_handle(void) static void http_auth_init(const char *url) { - char *at, *colon, *cp, *slash; + char *at, *colon, *cp, *slash, *decoded; int len; cp = strstr(url, "://"); @@ -322,16 +323,25 @@ static void http_auth_init(const char *url) user_name = xmalloc(len + 1); memcpy(user_name, cp, len); user_name[len] = '\0'; + decoded = url_decode(user_name); + free(user_name); + user_name = decoded; user_pass = NULL; } else { len = colon - cp; user_name = xmalloc(len + 1); memcpy(user_name, cp, len); user_name[len] = '\0'; + decoded = url_decode(user_name); + free(user_name); + user_name = decoded; len = at - (colon + 1); user_pass = xmalloc(len + 1); memcpy(user_pass, colon + 1, len); user_pass[len] = '\0'; + decoded = url_decode(user_pass); + free(user_pass); + user_pass = decoded; } } -- 1.7.2.3 ``` ## Sverre Rabbelier, 2010-11-13 21:33 Subject: Re: [PATCH] Fix username and password extraction from HTTP URLs Message-ID: URL: https://gitlist.dev/e/AANLkTinf3T7_7WGv_W%3Df2bD0xs-VPS6d3iSQn_rOKn5S%40mail.gmail.com In-Reply-To: <1289604025-6406-1-git-send-email-gabriel.corona@enst-bretagne.fr> ``` Heya, On Sat, Nov 13, 2010 at 00:20, Gabriel Corona wrote: > Change the authentification initialisation to percent-decode username > and password for HTTP URLs. Can has tests? -- Cheers, Sverre Rabbelier ```