# [PATCH] rebase: allow -X for non-recursive strategy

3 messages from 2010-11-09 to 2010-11-10. Participants: Martin von Zweigbergk, Jonathan Nieder, Sverre Rabbelier.
Thread: https://gitlist.dev/t/25696

## Martin von Zweigbergk, 2010-11-09 20:58

Subject: [PATCH] rebase: allow -X for non-recursive strategy
Message-ID: <1289336299-28282-1-git-send-email-martin.von.zweigbergk@gmail.com>
URL: https://gitlist.dev/e/1289336299-28282-1-git-send-email-martin.von.zweigbergk%40gmail.com

```
If any strategy options are passed to -X, the strategy will always be
set to 'recursive'. According to the documentation, it should default to
'recursive' if it is not set, but it should be possible to set it to
other values.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
---
Maybe I'm missing something, but it looks very much like that '-n'
should have been a '-z'. But still, 'strategy' is set to 'recursive' at
the start of the script and doesn't seem to be unset anywhere, so the
block shouldn't be necessary at all.

 git-rebase.sh |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/git-rebase.sh b/git-rebase.sh
index 42c0628..ec08f9c 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -312,10 +312,6 @@ do
 		esac
 		strategy_opts="$strategy_opts $(git rev-parse --sq-quote "--$newopt")"
 		do_merge=t
-		if test -n "$strategy"
-		then
-			strategy=recursive
-		fi
 		;;
 	-s=*|--s=*|--st=*|--str=*|--stra=*|--strat=*|--strate=*|\
 		--strateg=*|--strategy=*|\
-- 
1.7.3.2.167.ga361b

```

## Jonathan Nieder, 2010-11-10 08:55

Subject: Re: [PATCH] rebase: allow -X for non-recursive strategy
Message-ID: <20101110085554.GA10282@burratino>
URL: https://gitlist.dev/e/20101110085554.GA10282%40burratino
In-Reply-To: <1289336299-28282-1-git-send-email-martin.von.zweigbergk@gmail.com>

```
Martin von Zweigbergk wrote:

> Subject: [PATCH] rebase: allow -X for non-recursive strategy

I first read this as "allow -X option, which can be used to set a
non-recursive strategy".  Of course that was nonsense, but maybe
it can be made clearer?  e.g.

	rebase -X: do not clobber strategy

This fixes a regression introduced in v1.7.3-rc0~67^2 (2010-07-29).

```

## Sverre Rabbelier, 2010-11-10 18:55

Subject: Re: [PATCH] rebase: allow -X for non-recursive strategy
Message-ID: <AANLkTi=v+KUHDXYDWQXfpar+_jgMJgCn+TRuq1pPNKwB@mail.gmail.com>
URL: https://gitlist.dev/e/AANLkTi%3Dv%2BKUHDXYDWQXfpar%2B_jgMJgCn%2BTRuq1pPNKwB%40mail.gmail.com
In-Reply-To: <20101110085554.GA10282@burratino>

```
Heya,

On Wed, Nov 10, 2010 at 09:55, Jonathan Nieder <jrnieder@gmail.com> wrote:
> This fixes a regression introduced in v1.7.3-rc0~67^2 (2010-07-29).

Can has test?

-- 
Cheers,

Sverre Rabbelier

```