# [PATCH] builtin: make commit_notes function private to notes.c

1 messages from 2010-11-03 to 2010-11-03. Participants: Thiago Farina.
Thread: https://gitlist.dev/t/25625

## Thiago Farina, 2010-11-03 04:47

Subject: [PATCH] builtin: make commit_notes function private to notes.c
Message-ID: <48613a1a105a7dc6ed1fa76ac3cdae2ed2a859e4.1288759498.git.tfransosi@gmail.com>
URL: https://gitlist.dev/e/48613a1a105a7dc6ed1fa76ac3cdae2ed2a859e4.1288759498.git.tfransosi%40gmail.com

```
This function was exported in builtin.h but is only used on notes.c.

Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
 builtin.h       |    1 -
 builtin/notes.c |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/builtin.h b/builtin.h
index f2a25a0..8017ade 100644
--- a/builtin.h
+++ b/builtin.h
@@ -16,7 +16,6 @@ extern const char git_more_info_string[];
 extern void prune_packed_objects(int);
 extern int fmt_merge_msg(struct strbuf *in, struct strbuf *out,
 			 int merge_title, int shortlog_len);
-extern int commit_notes(struct notes_tree *t, const char *msg);
 
 struct notes_rewrite_cfg {
 	struct notes_tree **trees;
diff --git a/builtin/notes.c b/builtin/notes.c
index 6d07aac..89fe169 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -271,7 +271,7 @@ static int parse_reedit_arg(const struct option *opt, const char *arg, int unset
 	return parse_reuse_arg(opt, arg, unset);
 }
 
-int commit_notes(struct notes_tree *t, const char *msg)
+static int commit_notes(struct notes_tree *t, const char *msg)
 {
 	struct commit_list *parent;
 	unsigned char tree_sha1[20], prev_commit[20], new_commit[20];
-- 
1.7.3.2.90.gd4c43

```