threads / patch / 25436

patchgitweb: Fix test of highlighting support in t9500

Subject: [PATCH] gitweb: Fix test of highlighting support in t9500

## tl;dr

One message between Oct 13, 2010 and Oct 13, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jakub Narebski· Oct 13, 2010, 11:57 UTC · lore

The commit 7ce896b (Enable highlight executable path as a configuration option, 2010-09-21) forgot to update t9500 test.

While at it, describe highlight test better.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Noticed while running t9500 with `--debug` option.
 t/t9500-gitweb-standalone-no-errors.sh |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
Show changes to t/t9500-gitweb-standalone-no-errors.sh +6 −5
diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
index 4f2b9b0..21cd286 100755
--- a/t/t9500-gitweb-standalone-no-errors.sh
+++ b/t/t9500-gitweb-standalone-no-errors.sh
@@ -650,25 +650,26 @@ test_debug 'cat gitweb.log'
 # ----------------------------------------------------------------------
 # syntax highlighting
 
-cat >>gitweb_config.perl <<\EOF
-$feature{'highlight'}{'override'} = 1;
-EOF
 
 highlight --version >/dev/null 2>&1
 if [ $? -eq 127 ]; then
 	say "Skipping syntax highlighting test, because 'highlight' was not found"
 else
 	test_set_prereq HIGHLIGHT
+	cat >>gitweb_config.perl <<-\EOF
+	our $highlight_bin = "highlight";
+	$feature{'highlight'}{'override'} = 1;
+	EOF
 fi
 
 test_expect_success HIGHLIGHT \
-	'syntax highlighting (no highlight)' \
+	'syntax highlighting (no highlight, unknown syntax)' \
 	'git config gitweb.highlight yes &&
 	 gitweb_run "p=.git;a=blob;f=file"'
 test_debug 'cat gitweb.log'
 
 test_expect_success HIGHLIGHT \
-	'syntax highlighting (highlighted)' \
+	'syntax highlighting (highlighted, shell script)' \
 	'git config gitweb.highlight yes &&
 	 echo "#!/usr/bin/sh" > test.sh &&
 	 git add test.sh &&

← back to recent threads