# [PATCH 1/2] diffcore-pickaxe.c: remove unnecessary curly braces 2 messages from 2010-10-04 to 2010-10-04. Participants: Brandon Casey. Thread: https://gitlist.dev/t/25350 ## Brandon Casey, 2010-10-04 22:51 Subject: [PATCH 1/2] diffcore-pickaxe.c: remove unnecessary curly braces Message-ID: <7B67fI3-KUXNMcC63_TwzSz0R5IrKAQx1Xuml4Po0PYEJroaM3Kd71QYcXsJK6NsImqnd3Sd4t0@cipher.nrlssc.navy.mil> URL: https://gitlist.dev/e/7B67fI3-KUXNMcC63_TwzSz0R5IrKAQx1Xuml4Po0PYEJroaM3Kd71QYcXsJK6NsImqnd3Sd4t0%40cipher.nrlssc.navy.mil ``` From: Brandon Casey Signed-off-by: Brandon Casey --- diffcore-pickaxe.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c index 84195e4..3857099 100644 --- a/diffcore-pickaxe.c +++ b/diffcore-pickaxe.c @@ -269,9 +269,8 @@ static void diffcore_pickaxe_count(struct diff_options *o) diff_free_filepair(p); } - if (opts & DIFF_PICKAXE_REGEX) { + if (opts & DIFF_PICKAXE_REGEX) regfree(®ex); - } free(q->queue); *q = outq; -- 1.7.3.1 ``` ## Brandon Casey, 2010-10-04 22:51 Subject: [PATCH 2/2] diffcore-pickaxe.c: a void function shouldn't try to return something Message-ID: <7B67fI3-KUXNMcC63_TwzWm3yMw3MBsO-UId6DCtnNEi0B_PuBGQVjh0xBHrwD3jb3ptTcw5d38@cipher.nrlssc.navy.mil> URL: https://gitlist.dev/e/7B67fI3-KUXNMcC63_TwzWm3yMw3MBsO-UId6DCtnNEi0B_PuBGQVjh0xBHrwD3jb3ptTcw5d38%40cipher.nrlssc.navy.mil In-Reply-To: <7B67fI3-KUXNMcC63_TwzSz0R5IrKAQx1Xuml4Po0PYEJroaM3Kd71QYcXsJK6NsImqnd3Sd4t0@cipher.nrlssc.navy.mil> ``` From: Brandon Casey Signed-off-by: Brandon Casey --- diffcore-pickaxe.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c index 3857099..ea03b91 100644 --- a/diffcore-pickaxe.c +++ b/diffcore-pickaxe.c @@ -281,7 +281,7 @@ void diffcore_pickaxe(struct diff_options *o) { /* Might want to warn when both S and G are on; I don't care... */ if (o->pickaxe_opts & DIFF_PICKAXE_KIND_G) - return diffcore_pickaxe_grep(o); + diffcore_pickaxe_grep(o); else - return diffcore_pickaxe_count(o); + diffcore_pickaxe_count(o); } -- 1.7.3.1 ```