quoting in get_author_ident_from_commit

Hello,

I wonder about the quoting done in get_author_ident_from_commit's sed script.

It first does 's/'\''/'\''\\'\'\''/g', then 's/'\''/'\''\'\'\''/g' (the latter once for each resulting line). What sed actually sees is:

	s/'/'\\''/g
	s/'/'\''/g 

The second instruction only substitutes a single quote by three single quotes because \' is just interpreted as '.

So I think just removing the three occurences of the second substitute command just can be removed, as ''' effectively is the same as '.

Do I miss something?

(The first command was introduced in aa66c7ec77d474b737da607d6cb2d07f56628def, the second was introduced with git commit -m in fec3ef101c0f18bbf2400423dc70e686e9d25b0)

Thanks Uwe

The command 's/'\''/'\''\'\'\''/g' only triples single quotes:

	$ echo "What's up?" | sed 's/'\''/'\''\'\'\''/g'
	What'''s up?

This doesn't hurt as compared to a single single quote it only adds an empty string, but it makes the script needlessly complicated and hard to understand. The useful quoting is done by s/'\''/'\''\\'\'\''/g at the beginning of the script and only once for all three variables.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 git-sh-setup.sh |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Uwe Kleine-König  <u.kleine-koenig@pengutronix.de> writes:

Interesting. I think this was an ancient misconversion that dates back to June 2005 ;-)

Thanks.