# [PATCH] compat/nedmalloc: don't force NDEBUG on the rest of git

2 messages from 2010-09-11 to 2010-09-11. Participants: René Scharfe, Junio C Hamano.
Thread: https://gitlist.dev/t/25074

## René Scharfe, 2010-09-11 09:59

Subject: [PATCH] compat/nedmalloc: don't force NDEBUG on the rest of git
Message-ID: <4C8B52F6.5040609@lsrfire.ath.cx>
URL: https://gitlist.dev/e/4C8B52F6.5040609%40lsrfire.ath.cx

```
Define the nedmalloc feature configuration macros for nedmalloc.o, only.
This keeps assert(3) working for the rest of the git source; it was
turned off for nedmalloc users before by defining NDEBUG globally.

Also remove -DUSE_NED_ALLOCATOR as this macro isn't used anywhere.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
---
 Makefile |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index c27e8bc..4d45e04 100644
--- a/Makefile
+++ b/Makefile
@@ -1465,7 +1465,7 @@ ifdef NO_REGEX
 endif
 
 ifdef USE_NED_ALLOCATOR
-       COMPAT_CFLAGS += -DUSE_NED_ALLOCATOR -DOVERRIDE_STRDUP -DNDEBUG -DREPLACE_SYSTEM_ALLOCATOR -Icompat/nedmalloc
+       COMPAT_CFLAGS += -Icompat/nedmalloc
        COMPAT_OBJS += compat/nedmalloc/nedmalloc.o
 endif
 
@@ -1908,6 +1908,11 @@ ifdef NO_REGEX
 compat/regex/regex.o: EXTRA_CPPFLAGS = -DGAWK -DNO_MBSUPPORT
 endif
 
+ifdef USE_NED_ALLOCATOR
+compat/nedmalloc/nedmalloc.o: EXTRA_CPPFLAGS = \
+	-DNDEBUG -DOVERRIDE_STRDUP -DREPLACE_SYSTEM_ALLOCATOR
+endif
+
 git-%$X: %.o $(GITLIBS)
 	$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS)
 

```

## Junio C Hamano, 2010-09-11 17:23

Subject: Re: [PATCH] compat/nedmalloc: don't force NDEBUG on the rest of git
Message-ID: <7vocc4fb3t.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vocc4fb3t.fsf%40alter.siamese.dyndns.org
In-Reply-To: <4C8B52F6.5040609@lsrfire.ath.cx>

```
Makes sense; thanks.

```