threads / rfc / 24957

RFC patchgitweb.perl: tags snapshot link

Subject: [RFC PATCH] gitweb.perl: tags snapshot link

## tl;dr

3 messages between Sep 3, 2010 and Sep 14, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

WOLfgang Schricker· Sep 3, 2010, 11:42 UTC · lore
Hello,
I missed a snapshot link in my local repo:
====
tags
====
	tag | commit | shortlog | log | *snapshot*
I found this threads

<http://kerneltrap.org/mailarchive/git/2009/11/8/15785/thread> <http://thread.gmane.org/gmane.comp.version-control.git/132366>

and the code for "Smarter snapshot names" in 'gitwep.perl'.
My gitweb.perl-1.7.2.2.patch for "activating":

--- gitweb.perl.orig 2010-08-20 01:44:47.000000000 +0200 +++ gitweb.perl 2010-09-03 13:20:40.000000000 +0200

Show changes to diff +4 −0
@@ -4909,6 +4909,10 @@
 		} elsif ($tag{'reftype'} eq "blob") {
 			print " | " . $cgi->a({-href => href(action=>"blob_plain", hash=>$tag{'refid'})}, "raw");
 		}
+        my $snapshot_links = format_snapshot_links($tag{'fullname'});
+        if (defined $snapshot_links) {
+            print " | " . $snapshot_links;
+        }
 		print "</td>\n" .
 		      "</tr>";
 	}
-- 
Regards
*WOL* fgang *S* chricker
Giuseppe Bilotta· Sep 12, 2010, 23:25 UTC · re: WOLfgang Schricker · lore

Re: [RFC PATCH] gitweb.perl: tags snapshot link

WOLfgang Schricker wrote:
Show 31 quoted lines
> Hello,
> 
> I missed a snapshot link in my local repo:
> ====
> tags
> ====
> tag | commit | shortlog | log | *snapshot*
> 
> I found this threads
> 
> <http://kerneltrap.org/mailarchive/git/2009/11/8/15785/thread>
> <http://thread.gmane.org/gmane.comp.version-control.git/132366>
> 
> and the code for "Smarter snapshot names" in 'gitwep.perl'.
> 
> My gitweb.perl-1.7.2.2.patch for "activating":
> 
> 
> --- gitweb.perl.orig	2010-08-20 01:44:47.000000000 +0200
> +++ gitweb.perl	2010-09-03 13:20:40.000000000 +0200
> @@ -4909,6 +4909,10 @@
>  } elsif ($tag{'reftype'} eq "blob") {
>  print " | " . $cgi->a({-href => href(action=>"blob_plain",
>  hash=>$tag{'refid'})}, "raw"); }
> +        my $snapshot_links = format_snapshot_links($tag{'fullname'});
> +        if (defined $snapshot_links) {
> +            print " | " . $snapshot_links;
> +        }
>  print "</td>\n" .
>  "</tr>";
>  }

If I read the patch correctly, this would add a 'snapshot' link to the tag list view. Although the snapshot can already be obtained by clicking first on the commit or shortlog view, this would reduce the number of clicks necessary to obtain the snapshot. I believe it would be a good idea to have this. Wolfgang: wold you consider submitting it in a more appropriate form for inclusion?

If you do, you should probably also consider other places where such a link could be added, such as in tag view, where the nav bar currently reads

summary | shortlog | log | commit | commitdiff | tree
and "| snapshot" could be appended.
-- 
Giuseppe Bilotta
WOLfgang Schricker· Sep 14, 2010, 18:06 UTC · re: Giuseppe Bilotta · lore

Re: [RFC PATCH] gitweb.perl: tags snapshot link

Giuseppe Bilotta wrote:
Show 48 quoted lines
> WOLfgang Schricker wrote:
> 
>> Hello,
>>
>> I missed a snapshot link in my local repo:
>> ====
>> tags
>> ====
>> tag | commit | shortlog | log | *snapshot*
>>
>> I found this threads
>>
>> <http://kerneltrap.org/mailarchive/git/2009/11/8/15785/thread>
>> <http://thread.gmane.org/gmane.comp.version-control.git/132366>
>>
>> and the code for "Smarter snapshot names" in 'gitwep.perl'.
>>
>> My gitweb.perl-1.7.2.2.patch for "activating":
>>
>>
>> --- gitweb.perl.orig	2010-08-20 01:44:47.000000000 +0200
>> +++ gitweb.perl	2010-09-03 13:20:40.000000000 +0200
>> @@ -4909,6 +4909,10 @@
>>  } elsif ($tag{'reftype'} eq "blob") {
>>  print " | " . $cgi->a({-href => href(action=>"blob_plain",
>>  hash=>$tag{'refid'})}, "raw"); }
>> +        my $snapshot_links = format_snapshot_links($tag{'fullname'});
>> +        if (defined $snapshot_links) {
>> +            print " | " . $snapshot_links;
>> +        }
>>  print "</td>\n" .
>>  "</tr>";
>>  }
> 
> If I read the patch correctly, this would add a 'snapshot' link to the tag
> list view. Although the snapshot can already be obtained by clicking first
> on the commit or shortlog view, this would reduce the number of clicks
> necessary to obtain the snapshot. I believe it would be a good idea to have
> this. Wolfgang: wold you consider submitting it in a more appropriate form
> for inclusion?
> 
> If you do, you should probably also consider other places where such a link
> could be added, such as in tag view, where the nav bar currently reads
> 
> summary | shortlog | log | commit | commitdiff | tree
> 
> and "| snapshot" could be appended.
>

Yes. _Every_ available snapshot link looks <project>-<SHA1>.tgz. A 'v0.1' tag brings in the tag list project-v0.1.tgz now. I see eg. a relocatable 'latest' tag for project-latest.tgz.

-- 
Regards
*WOL* fgang *S* chricker

← back to recent threads