# [PATCH] post-receive-email: remove spurious commas in email subject. 3 messages from 2010-08-03 to 2010-08-11. Participants: Matthieu Moy, Kevin P. Fleming. Thread: https://gitlist.dev/t/24618 ## Matthieu Moy, 2010-08-03 13:10 Subject: [PATCH] post-receive-email: remove spurious commas in email subject. Message-ID: <1280841049-19091-1-git-send-email-Matthieu.Moy@imag.fr> URL: https://gitlist.dev/e/1280841049-19091-1-git-send-email-Matthieu.Moy%40imag.fr ``` The previous form produced subjects like [SCM] project.git branch, foo, updated. ... The new one will produce the lighter [SCM] project.git branch foo updated. ... Signed-off-by: Matthieu Moy --- I am the only one bothered by these extra commas in email subject? If so, I can live with it, but I thought I'd give it a try ;-). contrib/hooks/post-receive-email | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 30ae63d..09c5241 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -203,7 +203,7 @@ generate_email_header() # Generate header cat <<-EOF To: $recipients - Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe + Subject: ${emailprefix}$projectdesc $refname_type $short_refname ${change_type}d. $describe X-Git-Refname: $refname X-Git-Reftype: $refname_type X-Git-Oldrev: $oldrev -- 1.7.2.1.30.g18195 ``` ## Kevin P. Fleming, 2010-08-03 13:50 Subject: Re: [PATCH] post-receive-email: remove spurious commas in email subject. Message-ID: <4C581E98.6090504@digium.com> URL: https://gitlist.dev/e/4C581E98.6090504%40digium.com In-Reply-To: <1280841049-19091-1-git-send-email-Matthieu.Moy@imag.fr> ``` On 08/03/2010 08:10 AM, Matthieu Moy wrote: > The previous form produced subjects like > > [SCM] project.git branch, foo, updated. ... > > The new one will produce the lighter > > [SCM] project.git branch foo updated. ... > > Signed-off-by: Matthieu Moy > --- > I am the only one bothered by these extra commas in email subject? If > so, I can live with it, but I thought I'd give it a try ;-). No, I've removed them in our local copy as well, but never bothered to send the changes to the list :-) -- Kevin P. Fleming Digium, Inc. | Director of Software Technologies 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA skype: kpfleming | jabber: kfleming@digium.com Check us out at www.digium.com & www.asterisk.org ``` ## Matthieu Moy, 2010-08-11 08:14 Subject: [PATCH (resend)] post-receive-email: remove spurious commas in email subject Message-ID: <1281514453-23855-1-git-send-email-Matthieu.Moy@imag.fr> URL: https://gitlist.dev/e/1281514453-23855-1-git-send-email-Matthieu.Moy%40imag.fr In-Reply-To: <4C581E98.6090504@digium.com> ``` The previous form produced subjects like [SCM] project.git branch, foo, updated. ... The new one will produce the lighter [SCM] project.git branch foo updated. ... Signed-off-by: Matthieu Moy --- "Kevin P. Fleming" writes: > On 08/03/2010 08:10 AM, Matthieu Moy wrote: > >> I am the only one bothered by these extra commas in email subject? If >> so, I can live with it, but I thought I'd give it a try ;-). > > No, I've removed them in our local copy as well, but never bothered to > send the changes to the list :-) I guess it's time to get this into git.git then ... contrib/hooks/post-receive-email | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 30ae63d..09c5241 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -203,7 +203,7 @@ generate_email_header() # Generate header cat <<-EOF To: $recipients - Subject: ${emailprefix}$projectdesc $refname_type, $short_refname, ${change_type}d. $describe + Subject: ${emailprefix}$projectdesc $refname_type $short_refname ${change_type}d. $describe X-Git-Refname: $refname X-Git-Reftype: $refname_type X-Git-Oldrev: $oldrev -- 1.7.2.1.52.g95e25.dirty ```