threads / discuss / 24581

pre-commit hook and Aspell

Subject: pre-commit hook and Aspell

## tl;dr

3 messages between Jul 30, 2010 and Jul 30, 2010.

replies: 2people: 3as markdown or json

Stefan Bienert· Jul 30, 2010, 08:51 UTC · lore

Hi gits,

as instructed by the wiki, I just sent an request to the list without being subscribed...

I'm trying to setup a hook for my project which forces me to check the spelling of text (here: TeX) files, whenever they change. As spellchecker I use Aspell, which is giving me a headache at the moment. The problem is: Running the pre-commit script in the shell works, started as hook does not.

Here is my script (cut down to a minimalist version resembling the problem):

# SNIP #!/bin/sh

for my_p in $(git status --porcelain | awk '{ if ($0 ~ /\.(tex|sty)$/) {
print $2 } }')
do
    aspell -c -l en_GB -p $(pwd)/${my_cdup}share/dict/aspell.corb.pws
$my_p || exit 1
done
# SNAP

regards,

Stefan

-- 
Stefan Bienert
Zentrum fuer Bioinformatik
Universitaet Hamburg
Bundesstrasse 43
20146 Hamburg
Germany

Email: bienert@zbh.uni-hamburg.de
Phone:  +49 (40) 42838 7345
Fax:    +49 (40) 42838 7332

Junio C Hamano· Jul 30, 2010, 15:59 UTC · re: Stefan Bienert · lore

Re: pre-commit hook and Aspell

Stefan Bienert <bienert@zbh.uni-hamburg.de> writes:

Show 7 quoted lines

> Here is my script (cut down to a minimalist version resembling the problem):
>
> # SNIP
> #!/bin/sh
>
> for my_p in $(git status --porcelain | awk '{ if ($0 ~ /\.(tex|sty)$/) {
> print $2 } }')

A tangent; perhaps "git status --porcelain '*.tex' '*.sty'" would help you lose the pipe and awk.

> do
>     aspell -c -l en_GB -p $(pwd)/${my_cdup}share/dict/aspell.corb.pws
> $my_p || exit 1

Not quite sure what my-cdup is here, but probably you would want to have something like this at the top of the script?

	#!/bin/sh
	"cd .."

Jeff King· Jul 30, 2010, 18:21 UTC · re: Stefan Bienert · lore

Re: pre-commit hook and Aspell

On Fri, Jul 30, 2010 at 10:51:28AM +0200, Stefan Bienert wrote:

Show 5 quoted lines

> I'm trying to setup a hook for my project which forces me to check the
> spelling of text (here: TeX) files, whenever they change. As
> spellchecker I use Aspell, which is giving me a headache at the moment.
> The problem is: Running the pre-commit script in the shell works,
> started as hook does not.

Hooks run without stdio connected to the tty. Have you tried doing "aspell </dev/tty >/dev/tty" in your hook?

-Peff