# [PATCH 3/4] revert: don't print "Finished one cherry-pick." if commit failed

2 messages from 2010-07-13 to 2010-07-15. Participants: Christian Couder, Jonathan Nieder.
Thread: https://gitlist.dev/t/24403

## Christian Couder, 2010-07-13 23:28

Subject: [PATCH 3/4] revert: don't print "Finished one cherry-pick." if commit failed
Message-ID: <20100713232816.7738.202.chriscool@tuxfamily.org>
URL: https://gitlist.dev/e/20100713232816.7738.202.chriscool%40tuxfamily.org

```

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin/revert.c |   17 +++++------------
 1 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/builtin/revert.c b/builtin/revert.c
index b84b5b8..ec931bd 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -518,24 +518,17 @@ static int do_pick_commit(void)
 			mebuf.buf, help_msg());
 		rerere(allow_rerere_auto);
 	} else {
-		fprintf(stderr, "Finished one %s.\n", mebuf.buf);
+		if (!no_commit)
+			res = run_git_commit(defmsg);
+		if (!res)
+			fprintf(stderr, "Finished one %s.\n", mebuf.buf);
 	}
 
 	strbuf_release(&mebuf);
 	free_message(&msg);
-
-	if (res)
-		return 1;
-
-	if (!no_commit) {
-		res = run_git_commit(defmsg);
-		free(defmsg);
-		return res;
-	}
-
 	free(defmsg);
 
-	return 0;
+	return res;
 }
 
 static void prepare_revs(struct rev_info *revs)
-- 
1.7.2.rc1.215.g2dff2.dirty

```

## Jonathan Nieder, 2010-07-15 22:42

Subject: Re: [PATCH 3/4] revert: don't print "Finished one cherry-pick." if commit failed
Message-ID: <20100715224251.GA7253@burratino>
URL: https://gitlist.dev/e/20100715224251.GA7253%40burratino
In-Reply-To: <20100713232816.7738.202.chriscool@tuxfamily.org>

```
Christian Couder wrote:

> Subject: revert: don't print "Finished one cherry-pick." if commit failed

This and the previous one make the code much easier to read.
So for what it’s worth I like them.

```