# [PATCH] test-lib: Don't write test-results when HARNESS_ACTIVE 2 messages from 2010-07-08 to 2010-08-11. Participants: Ævar Arnfjörð Bjarmason. Thread: https://gitlist.dev/t/24339 ## Ævar Arnfjörð Bjarmason, 2010-07-08 23:34 Subject: [PATCH] test-lib: Don't write test-results when HARNESS_ACTIVE Message-ID: <1278632080-31949-1-git-send-email-avarab@gmail.com> URL: https://gitlist.dev/e/1278632080-31949-1-git-send-email-avarab%40gmail.com ``` TAP harnesses don't need to read test-results/*, since they keep track of the number of passing/failing tests internally. Skip the generation of these files when HARNESS_ACTIVE is set. It's now possible to run the Git test suite without writing anything to the t/ directory at all if you use a TAP harness and the --root switch: cd t sudo mount -t tmpfs none /tmp/memory -o size=300m prove -j9 ./t[0-9]*.sh :: --root=/tmp/memory The I/O that the ~500 test-results/* files contributed was very minimal, but I thought this was worth mentioning. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/test-lib.sh | 23 +++++++++++++---------- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index ac496aa..5f2959f 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -633,16 +633,19 @@ test_create_repo () { test_done () { GIT_EXIT_OK=t - test_results_dir="$TEST_DIRECTORY/test-results" - mkdir -p "$test_results_dir" - test_results_path="$test_results_dir/${0%.sh}-$$" - - echo "total $test_count" >> $test_results_path - echo "success $test_success" >> $test_results_path - echo "fixed $test_fixed" >> $test_results_path - echo "broken $test_broken" >> $test_results_path - echo "failed $test_failure" >> $test_results_path - echo "" >> $test_results_path + + if test -z "$HARNESS_ACTIVE"; then + test_results_dir="$TEST_DIRECTORY/test-results" + mkdir -p "$test_results_dir" + test_results_path="$test_results_dir/${0%.sh}-$$" + + echo "total $test_count" >> $test_results_path + echo "success $test_success" >> $test_results_path + echo "fixed $test_fixed" >> $test_results_path + echo "broken $test_broken" >> $test_results_path + echo "failed $test_failure" >> $test_results_path + echo "" >> $test_results_path + fi if test "$test_fixed" != 0 then -- 1.7.0.4 ``` ## Ævar Arnfjörð Bjarmason, 2010-08-11 19:37 Subject: [PATCH v2] test-lib: Don't write test-results when HARNESS_ACTIVE Message-ID: <1281555451-6847-1-git-send-email-avarab@gmail.com> URL: https://gitlist.dev/e/1281555451-6847-1-git-send-email-avarab%40gmail.com In-Reply-To: <1278632080-31949-1-git-send-email-avarab@gmail.com> ``` TAP harnesses don't need to read test-results/*, since they keep track of the number of passing/failing tests internally. Skip the generation of these files when HARNESS_ACTIVE is set. It's now possible to run the Git test suite without writing anything to the t/ directory at all if you use a TAP harness and the --root switch: cd t sudo mount -t tmpfs none /tmp/memory -o size=300m prove -j9 ./t[0-9]*.sh :: --root=/tmp/memory The I/O that the ~500 test-results/* files contributed was very minimal, but I thought this was worth mentioning. Signed-off-by: Ævar Arnfjörð Bjarmason --- This one fell through the cracks, and conflicted with Thomas's later "Only run aggregate-results over actual counts" patch. Please apply it, it keeps conflicting with local changes I have to the test-lib.sh t/test-lib.sh | 23 +++++++++++++---------- 1 files changed, 13 insertions(+), 10 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 4e73fff..956f1a5 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -646,16 +646,19 @@ test_create_repo () { test_done () { GIT_EXIT_OK=t - test_results_dir="$TEST_DIRECTORY/test-results" - mkdir -p "$test_results_dir" - test_results_path="$test_results_dir/${0%.sh}-$$.counts" - - echo "total $test_count" >> $test_results_path - echo "success $test_success" >> $test_results_path - echo "fixed $test_fixed" >> $test_results_path - echo "broken $test_broken" >> $test_results_path - echo "failed $test_failure" >> $test_results_path - echo "" >> $test_results_path + + if test -z "$HARNESS_ACTIVE"; then + test_results_dir="$TEST_DIRECTORY/test-results" + mkdir -p "$test_results_dir" + test_results_path="$test_results_dir/${0%.sh}-$$.counts" + + echo "total $test_count" >> $test_results_path + echo "success $test_success" >> $test_results_path + echo "fixed $test_fixed" >> $test_results_path + echo "broken $test_broken" >> $test_results_path + echo "failed $test_failure" >> $test_results_path + echo "" >> $test_results_path + fi if test "$test_fixed" != 0 then -- 1.7.2.1.295.gdf931 ```