threads / patch / 24159

patchcheckout: Better error message on invalid branch name

Subject: [PATCH] checkout: Better error message on invalid branch name

## tl;dr

3 messages between Jun 21, 2010 and Jun 21, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ævar Arnfjörð Bjarmason· Jun 21, 2010, 18:53 UTC · lore

Change the error message for `git checkout -b "I LOVE YOU"' and other invalid branch names to say what branch names are invalid, rather than just saying we don't like it.

Before:

    $ git checkout -b "I LOVE YOU"
    fatal: git checkout: we do not like 'I LOVE YOU' as a branch name.

After:

    $ git checkout -b "I LOVE YOU"
    fatal: git checkout: The name "I LOVE YOU" is not a valid Git branch name.
    A branch name can not:
        - Have a path component that begins with "."
        - Have a double dot ".."
        - Have an ASCII control character, "~", "^", ":" or SP, anywhere
        - End with a "/"
        - End with ".lock"
        - Contain a "\" (backslash

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---

Git didn't like my branch name, but I didn't like its error message. Here's a fix for it.

 builtin/checkout.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

Show changes to builtin/checkout.c +9 −1

diff --git a/builtin/checkout.c b/builtin/checkout.c
index 1994be9..fec8335 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -856,7 +856,15 @@ no_reference:
 	if (opts.new_branch) {
 		struct strbuf buf = STRBUF_INIT;
 		if (strbuf_check_branch_ref(&buf, opts.new_branch))
-			die("git checkout: we do not like '%s' as a branch name.",
+			die("git checkout: The name \"%s\" is not a valid branch name.\n"
+			    "A branch name can not:\n"
+			    /* From the comment for bad_ref_char in refs.c */
+			    "    - Have a path component that begins with \".\"\n"
+			    "    - Have a double dot \"..\"\n"
+			    "    - Have an ASCII control character, \"~\", \"^\", \":\" or SP, anywhere\n"
+			    "    - End with a \"/\"\n"
+			    "    - End with \".lock\"\n"
+			    "    - Contain a \"\\\" (backslash)",
 			    opts.new_branch);
 		if (!get_sha1(buf.buf, rev))
 			die("git checkout: branch %s already exists", opts.new_branch);

-- 
1.7.1.251.g92a7

Junio C Hamano· Jun 21, 2010, 20:58 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] checkout: Better error message on invalid branch name

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 20 quoted lines

> Change the error message for `git checkout -b "I LOVE YOU"' and other
> invalid branch names to say what branch names are invalid, rather than
> just saying we don't like it.
>
> Before:
>
>     $ git checkout -b "I LOVE YOU"
>     fatal: git checkout: we do not like 'I LOVE YOU' as a branch name.
>
> After:
>
>     $ git checkout -b "I LOVE YOU"
>     fatal: git checkout: The name "I LOVE YOU" is not a valid Git branch name.
>     A branch name can not:
>         - Have a path component that begins with "."
>         - Have a double dot ".."
>         - Have an ASCII control character, "~", "^", ":" or SP, anywhere
>         - End with a "/"
>         - End with ".lock"
>         - Contain a "\" (backslash

Cluttering the output without protecting it with "advice" does not look like a "fix" nor improvement.

Ævar Arnfjörð Bjarmason· Jun 21, 2010, 21:09 UTC · re: Junio C Hamano · lore

Re: [PATCH] checkout: Better error message on invalid branch name

On Mon, Jun 21, 2010 at 20:58, Junio C Hamano <gitster@pobox.com> wrote:

> Cluttering the output without protecting it with "advice" does not look
> like a "fix" nor improvement.

The short version of the message would also need to be fixed then, to do that properly would require bigger changes in the return code of bad_ref_char and the functions that call it. Then we could have e.g.:

    $ git checkout -b "I LOVE YOU"
    fatal: git checkout: Branch name cannot contain ' ';  marked by
<-- HERE in 'I ' <-- HERE

Similar to what you get from:

    $ perl -e '/I LOVE [/'

That would also make the long version unnecessary, and maybe improve some other error messages that deal with ref names.