threads / discuss / 24123

[GSoC update] Splitting gitweb & developing write functionalities

Subject: [GSoC update] Splitting gitweb & developing write functionalities

## tl;dr

7 messages between Jun 15, 2010 and Jun 18, 2010.

replies: 6people: 3as markdown or json

Pavan Kumar Sunkara· Jun 15, 2010, 20:03 UTC · lore
Hi,

I know it's been late to send a GSOC update but here is mine for the first few weeks of GSOC coding period.

Patch list:
gitweb: Use @diff_opts while using format-patch [master]
gitweb: Move static files into seperate subdirectory [next]
gitweb: Set default destination directory for installing gitweb [next]
git-instaweb: Put httpd logs in a "$httpd_only" subdirectory [next]
git-instaweb: Configure it to work with new gitweb structure [next]
git-web--browse: Add support for google chrome and chromium [next]
Makefile: Use $(sharedir)/gitweb for target 'install-gitweb' [next]
git-instaweb: Add option to reuse previous config file [next]

git-instaweb: Add support for --reuse-config using gitconfig [waiting for Junio] http://kerneltrap.org/mailarchive/git/2010/6/3/31711

gitweb: Create Gitweb::Git module [Work in Progress] gitweb: Create Gitweb::Config module [Work in Progress] gitweb: Create Gitweb::Request module [Work in Progress] gitweb: Create Gitweb::Escape module [Work in Progress] gitweb: Create Gitweb::View module [Work in Progress] gitweb: Create Gitweb::Util module [Work in Progress] gitweb: Create Gitweb::RepoConfig module [Work in Progress] gitweb: Create Gitweb::Format module [Work in Progress] gitweb: Create Gitweb::Parse module [Work in Progress]

Petr Baudis· Jun 15, 2010, 20:17 UTC · re: Pavan Kumar Sunkara · lore

Re: [GSoC update] Splitting gitweb & developing write functionalities

Hi!
On Wed, Jun 16, 2010 at 01:33:30AM +0530, Pavan Kumar Sunkara wrote:
Show 9 quoted lines
> gitweb: Use @diff_opts while using format-patch [master]
> 
> gitweb: Move static files into seperate subdirectory [next]
> gitweb: Set default destination directory for installing gitweb [next]
> git-instaweb: Put httpd logs in a "$httpd_only" subdirectory [next]
> git-instaweb: Configure it to work with new gitweb structure [next]
> git-web--browse: Add support for google chrome and chromium [next]
> Makefile: Use $(sharedir)/gitweb for target 'install-gitweb' [next]
> git-instaweb: Add option to reuse previous config file [next]
Good job!
Show 5 quoted lines
> gitweb: Create Gitweb::Git module [Work in Progress]
> gitweb: Create Gitweb::Config module [Work in Progress]
> gitweb: Create Gitweb::Request module [Work in Progress]
> gitweb: Create Gitweb::Escape module [Work in Progress]
> gitweb: Create Gitweb::View module [Work in Progress]
(Is this the Gitweb::HTML module? Why have you renamed it?)
> gitweb: Create Gitweb::Util module [Work in Progress]
> gitweb: Create Gitweb::RepoConfig module [Work in Progress]
> gitweb: Create Gitweb::Format module [Work in Progress]
> gitweb: Create Gitweb::Parse module [Work in Progress]

Ok, so we seem to be behind a bit now compared to the timeline? Perhaps no big deal but we should be careful; maybe you will have to also start brewing some write-support patches while the structure and details of the split modules is still undergoing discussion.

Keep up the good work!
-- 
				Petr "Pasky" Baudis
The true meaning of life is to plant a tree under whose shade
you will never sit.
Pavan Kumar Sunkara· Jun 15, 2010, 20:33 UTC · re: Petr Baudis · lore

Re: [GSoC update] Splitting gitweb & developing write functionalities

On Wed, Jun 16, 2010 at 1:47 AM, Petr Baudis <pasky@suse.cz> wrote:
Show 22 quoted lines
> Hi!
>
> On Wed, Jun 16, 2010 at 01:33:30AM +0530, Pavan Kumar Sunkara wrote:
>> gitweb: Use @diff_opts while using format-patch [master]
>>
>> gitweb: Move static files into seperate subdirectory [next]
>> gitweb: Set default destination directory for installing gitweb [next]
>> git-instaweb: Put httpd logs in a "$httpd_only" subdirectory [next]
>> git-instaweb: Configure it to work with new gitweb structure [next]
>> git-web--browse: Add support for google chrome and chromium [next]
>> Makefile: Use $(sharedir)/gitweb for target 'install-gitweb' [next]
>> git-instaweb: Add option to reuse previous config file [next]
>
> Good job!
>
>> gitweb: Create Gitweb::Git module [Work in Progress]
>> gitweb: Create Gitweb::Config module [Work in Progress]
>> gitweb: Create Gitweb::Request module [Work in Progress]
>> gitweb: Create Gitweb::Escape module [Work in Progress]
>> gitweb: Create Gitweb::View module [Work in Progress]
>
> (Is this the Gitweb::HTML module? Why have you renamed it?)

Yeah I thought it would be better if I have this named as View rather than HTML :)

Show 13 quoted lines
>
>> gitweb: Create Gitweb::Util module [Work in Progress]
>> gitweb: Create Gitweb::RepoConfig module [Work in Progress]
>> gitweb: Create Gitweb::Format module [Work in Progress]
>> gitweb: Create Gitweb::Parse module [Work in Progress]
>
> Ok, so we seem to be behind a bit now compared to the timeline? Perhaps
> no big deal but we should be careful; maybe you will have to also start
> brewing some write-support patches while the structure and details of
> the split modules is still undergoing discussion.
>
> Keep up the good work!
>

Thanks, I would like to start on the writing feature soon enough.

Pavan.
Petr Baudis· Jun 15, 2010, 20:57 UTC · re: Pavan Kumar Sunkara · lore

Re: [GSoC update] Splitting gitweb & developing write functionalities

  Hi!
On Wed, Jun 16, 2010 at 02:03:50AM +0530, Pavan Kumar Sunkara wrote:
Show 5 quoted lines
> >> gitweb: Create Gitweb::View module [Work in Progress]
> >
> > (Is this the Gitweb::HTML module? Why have you renamed it?)
> Yeah I thought it would be better if I have this named as View rather
> than HTML :)
  I'm just a bit surprised since I have thought we have agreed that
Gitweb::View is much more misleading name for what Gitweb::HTML actually
is, hinting at a MVC structure that simply is not there at any level.
You are welcome to differ in opinion but then I would expect you to
continue that discussion. :-)
-- 
				Petr "Pasky" Baudis
The true meaning of life is to plant a tree under whose shade
you will never sit.
Pavan Kumar Sunkara· Jun 15, 2010, 21:13 UTC · re: Petr Baudis · lore

Re: [GSoC update] Splitting gitweb & developing write functionalities

On Wed, Jun 16, 2010 at 2:27 AM, Petr Baudis <pasky@suse.cz> wrote:
Show 15 quoted lines
>  Hi!
>
> On Wed, Jun 16, 2010 at 02:03:50AM +0530, Pavan Kumar Sunkara wrote:
>> >> gitweb: Create Gitweb::View module [Work in Progress]
>> >
>> > (Is this the Gitweb::HTML module? Why have you renamed it?)
>> Yeah I thought it would be better if I have this named as View rather
>> than HTML :)
>
>  I'm just a bit surprised since I have thought we have agreed that
> Gitweb::View is much more misleading name for what Gitweb::HTML actually
> is, hinting at a MVC structure that simply is not there at any level.
> You are welcome to differ in opinion but then I would expect you to
> continue that discussion. :-)
>

Yes but after a long thought, I decided that the name to be changed to View because this module contains all the subroutines regarding the gitweb viewing functions.

Thanks, Pavan.

Petr Baudis· Jun 16, 2010, 07:30 UTC · re: Pavan Kumar Sunkara · lore

Re: [GSoC update] Splitting gitweb & developing write functionalities

On Wed, Jun 16, 2010 at 02:43:57AM +0530, Pavan Kumar Sunkara wrote:
> Yes but after a long thought, I decided that the name to be changed to
> View because this module contains all the subroutines regarding the
> gitweb viewing functions.

But then you will need to continue the discussion in the respective therad and present counter-arguments to our (my?) arguments, or you will get NAKs.

(It's not like this is a totally crucial issue, but I'm now rather annoyed as what's the point of discussing stuff if it can be all discarded at a whim?)

				Petr "Pasky" Baudis
Jakub Narebski· Jun 18, 2010, 20:33 UTC · re: Petr Baudis · lore

Re: [GSoC update] Splitting gitweb & developing write functionalities

Petr Baudis <pasky@suse.cz> writes:
> On Wed, Jun 16, 2010 at 02:43:57AM +0530, Pavan Kumar Sunkara wrote:
Show 11 quoted lines
> > Yes but after a long thought, I decided that the name to be changed to
> > View because this module contains all the subroutines regarding the
> > gitweb viewing functions.
> 
> But then you will need to continue the discussion in the respective
> therad and present counter-arguments to our (my?) arguments, or you will
> get NAKs.
> 
> (It's not like this is a totally crucial issue, but I'm now rather
> annoyed as what's the point of discussing stuff if it can be all
> discarded at a whim?)

On the other hand gitweb output is not limited to HTML only: it includes text/plain ("raw" blob aka 'blob_plain' for text files, 'patches' / 'patch', 'projects_index'), feed formats: OPML, RSS, Atom, and binary output ("raw" blob for binary files like images, 'snapshot').

But I don't know if Gitweb::View includes subroutines related to all those things.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

← back to recent threads