threads / patch / 24073

patchgitk: Decode the "-n" argument properly for Edit View

Subject: [PATCH] gitk: Decode the "-n" argument properly for Edit View

## tl;dr

One message between Jun 10, 2010 and Jun 10, 2010. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Jim Ramsay· Jun 10, 2010, 16:33 UTC · lore

Running 'gitk -n 42' and selecting View > Edit View... would previously put the '-n' half of the argument-pair in the box labeled "Additional arguments to git log" and the '42' in "Branches & Tags". Parse this pair properly and use the numerical portion for the 'limit' value.

Signed-off-by: Jim Ramsay <i.am@jimramsay.com>
---
 gitk-git/gitk |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
Show changes to gitk-git/gitk +11 −0
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 1b0e09a..f93e7e5 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -3907,6 +3907,17 @@ proc decode_view_opts {n view_args} {
     set oargs [list]
     set refargs [list]
     foreach arg $view_args {
+	# Decode 2-argument '-n 42' as 'limit'
+	if {[info exists haslimitarg]} {
+	    set newviewopts($n,limit) $arg
+	    set found(limit) 1
+	    unset haslimitarg
+	    continue
+	}
+	if {$arg eq "-n"} {
+	    set haslimitarg 1
+	    continue
+	}
 	if {[regexp -- {^-([0-9]+)$} $arg arg cnt]
 	    && ![info exists found(limit)]} {
 	    set newviewopts($n,limit) $cnt
-- 
1.7.0.2



-- 
Jim Ramsay

← back to recent threads