Hi,
I notice that there are files like "git-core.files". Wouldn't it be better to generate them from the Makefile? The same mechanism could then be used to make RPMs from the same Makefile.
Ciao, Dscho
threads / discuss / 2403
Subject: Regarding: Debian: packaging updates.
Hi,
I notice that there are files like "git-core.files". Wouldn't it be better to generate them from the Makefile? The same mechanism could then be used to make RPMs from the same Makefile.
Ciao, Dscho
Re: Regarding: Debian: packaging updates.
Hi,
Johannes Schindelin wrote:
> I notice that there are files like "git-core.files". Wouldn't it be better > to generate them from the Makefile? The same mechanism could then be used > to make RPMs from the same Makefile.
I'm currently in the process of working my way through the current packaging, and there is quite a lot I am going to simplify. As the Debian build scripts do not expect this file to be autogenerated, I think it would be counterproductive to do so; it can seriously affect reproducability of builds.
(actually, I would like to ask not to fix things in the Debian packaging that aren't broken, as providing an upgrade path for earlier versions will be a lot less painful then)
Simon
Re: Regarding: Debian: packaging updates.
Simon Richter <sjr@debian.org> writes:
> I'm currently in the process of working my way through the current > packaging, and there is quite a lot I am going to simplify. As the > Debian build scripts do not expect this file to be autogenerated, I > think it would be counterproductive to do so; it can seriously affect > reproducability of builds. > > (actually, I would like to ask not to fix things in the Debian packaging > that aren't broken, as providing an upgrade path for earlier versions > will be a lot less painful then)
Noted. I just barely speak enough deb to build binary packages, and the source packaging and upload procedure are something I've never bothered to learn, so I won't be touching that area from now on.
Since you have debian.org e-mail address, perhaps you can feed me patches to debian/ area and deb: rule in the main Makefile? I was asked to use dpkg-buildpackage/dpkg-genchanges and produce the *.changes file as well by somebody who maintains his own private apt source. I'd appreciate if you can take care of it when you update the Makefile deb: rule as well, if the *.changes file request makes sense to you.
Re: Regarding: Debian: packaging updates.
Hi,
Junio C Hamano wrote:
> Since you have debian.org e-mail address, perhaps you can feed > me patches to debian/ area and deb: rule in the main Makefile?
Sure. I have also talked this over with a few people and am going to make official uploads occasionally.
> I'd appreciate if you can take care of it > when you update the Makefile deb: rule as well, if the *.changes > file request makes sense to you.
Not really. *.changes files make only sense if you are running archive maintenance software, and the need to do that should go away with reasonably up-to-date packages being in the archive RSN.
Simon
Re: Regarding: Debian: packaging updates.
Simon Richter <sjr@debian.org> writes:
> Junio C Hamano wrote: > >> Since you have debian.org e-mail address, perhaps you can feed >> me patches to debian/ area and deb: rule in the main Makefile? > > Sure. I have also talked this over with a few people and am going to > make official uploads occasionally.
Simon, I've received a patch to do *.changes file from Carl Baldwin, and with his permission I am forwarding it to you, hoping that you could include it (or reject it with explanation to Carl and me) when you feed me your debian/ updates. Carl says he wants to use dupload to populate his private apt-get repository and the process wants the generated *.changes file.
Myself, I've been either installing with "dpkg -i" directly or populating the apt-get repository by hand (yuck) but if dupload is the preferred way to maintain private apt-get repository and if having *.changes file helps that procedure, then...
---
diff --git a/Makefile b/Makefile index bfdaf76..c1fcecb 100644 --- a/Makefile +++ b/Makefile @@ -452,8 +452,7 @@ rpm: dist deb: dist rm -rf $(GIT_TARNAME) $(TAR) zxf $(GIT_TARNAME).tar.gz - dpkg-source -b $(GIT_TARNAME) - cd $(GIT_TARNAME) && fakeroot debian/rules binary + cd $(GIT_TARNAME) && dpkg-buildpackage -rfakeroot -us -uc ### Cleaning rules @@ -464,6 +463,7 @@ clean: rm -rf $(GIT_TARNAME) rm -f $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz rm -f git-core_$(GIT_VERSION)-*.dsc + rm -f git-core_$(GIT_VERSION)-*.changes rm -f git-*_$(GIT_VERSION)-*.deb $(MAKE) -C Documentation/ clean $(MAKE) -C templates clean