# Bug#428413: commit mail sender messes up order of arguments 1 messages from 2010-05-16 to 2010-05-16. Participants: Jonathan Nieder. Thread: https://gitlist.dev/t/23819 ## Jonathan Nieder, 2010-05-16 01:26 Subject: Bug#428413: commit mail sender messes up order of arguments Message-ID: <20100516012615.GA5599@progeny.tock> URL: https://gitlist.dev/e/20100516012615.GA5599%40progeny.tock In-Reply-To: <20070611150405.GA4211@lapse.madduck.net> ``` tags 428413 - wontfix reassign 428413 git git-core/1:1.5.2.1-1 found 428413 git/1:1.7.1-1 quit martin f krafft wrote: > According to the default hooks/post-receive file, the hook is called > with three arguments on stdin: > > > > This leads people to assume that in command-line mode, the order > should be the same. But it's not, because the email hook instead > calls: > > generate_email $2 $3 $1 > > this is at least misleading and not documented anywhere. So maybe we should document it. I haven’t checked that the below is actually true; I just took the commit message to v1.5.1~9 and paraphrased it. Thoughts? Signed-off-by: Jonathan Nieder --- contrib/hooks/post-receive-email | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 58a35c8..30ae63d 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -23,6 +23,13 @@ # possible for the email to be from someone other than the person doing the # push. # +# To help with debugging and use on pre-v1.5.1 git servers, this script will +# also obey the interface of hooks/update, taking its arguments on the +# command line. Unfortunately, hooks/update is called once for each ref. +# To avoid firing one email per ref, this script just prints its output to +# the screen when used in this mode. The output can then be redirected if +# wanted. +# # Config # ------ # hooks.mailinglist -- 1.7.1 -- To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org ```