# git fast-import crashes importing commits with more than one author 6 messages from 2010-05-01 to 2010-05-03. Participants: Giedrius Slavinskas, Andreas Schwab, Dmitrijs Ledkovs, Junio C Hamano, Andreas Ericsson. Thread: https://gitlist.dev/t/23653 ## Giedrius Slavinskas, 2010-05-01 15:43 Subject: git fast-import crashes importing commits with more than one author Message-ID: <1272728636.27562.12.camel@localhost.localdomain> URL: https://gitlist.dev/e/1272728636.27562.12.camel%40localhost.localdomain ``` git fast-import does not support commits with more than one author. I try to import bzr repository and it crashes. Here is info how to make bzr commit that couldn't be imported to git http://doc.bazaar.canonical.com/latest/en/user-guide/recording_changes.html#giving-credit-for-a-change ``` ## Andreas Schwab, 2010-05-01 16:36 Subject: Re: git fast-import crashes importing commits with more than one author Message-ID: URL: https://gitlist.dev/e/m2ocgztw7z.fsf%40igel.home In-Reply-To: <1272728636.27562.12.camel@localhost.localdomain> ``` Giedrius Slavinskas writes: > git fast-import does not support commits with more than one author. I > try to import bzr repository and it crashes. You can find a patch here: Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ``` ## Dmitrijs Ledkovs, 2010-05-01 16:47 Subject: Re: git fast-import crashes importing commits with more than one author Message-ID: URL: https://gitlist.dev/e/g2x86ecb3c71005010947x662aad8bn1fc2950d741b07e7%40mail.gmail.com In-Reply-To: ``` On 1 May 2010 17:36, Andreas Schwab wrote: > Giedrius Slavinskas writes: > >> git fast-import does not support commits with more than one author. I >> try to import bzr repository and it crashes. > > You can find a patch here: > > > Andreas. Although this is fine shouldn't we put the additional authors to the signed-off: lines in the git commit message? --Dima. ``` ## Junio C Hamano, 2010-05-01 17:19 Subject: Re: git fast-import crashes importing commits with more than one author Message-ID: <7vbpcz5ylz.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vbpcz5ylz.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Dmitrijs Ledkovs writes: > On 1 May 2010 17:36, Andreas Schwab wrote: >> Giedrius Slavinskas writes: >> >>> git fast-import does not support commits with more than one author. I >>> try to import bzr repository and it crashes. >> >> You can find a patch here: >> >> >> Andreas. > > Although this is fine shouldn't we put the additional authors to the > signed-off: lines in the git commit message? If an author didn't sign-off in the log message, a tool shouldn't add it automatically. Doing so makes S-o-b meaningless. ``` ## Dmitrijs Ledkovs, 2010-05-01 17:28 Subject: Re: git fast-import crashes importing commits with more than one author Message-ID: URL: https://gitlist.dev/e/y2m86ecb3c71005011028t7f581ce7t98256aa8f8bbb0bf%40mail.gmail.com In-Reply-To: <7vbpcz5ylz.fsf@alter.siamese.dyndns.org> ``` On 1 May 2010 18:19, Junio C Hamano wrote: > Dmitrijs Ledkovs writes: > >> On 1 May 2010 17:36, Andreas Schwab wrote: >>> Giedrius Slavinskas writes: >>> >>>> git fast-import does not support commits with more than one author. I >>>> try to import bzr repository and it crashes. >>> >>> You can find a patch here: >>> >>> >>> Andreas. >> >> Although this is fine shouldn't we put the additional authors to the >> signed-off: lines in the git commit message? > > If an author didn't sign-off in the log message, a tool shouldn't add it > automatically.  Doing so makes S-o-b meaningless. > Fair enough. I'm justing thinking on how to support round-tripping to bzr with import/export cause there are a few other properties bzr needs to recreate identical repository. Is it more appropriate for the marks format revision (bzr side of it)? ``` ## Andreas Ericsson, 2010-05-03 08:59 Subject: Re: git fast-import crashes importing commits with more than one author Message-ID: <4BDE9065.5030500@op5.se> URL: https://gitlist.dev/e/4BDE9065.5030500%40op5.se In-Reply-To: ``` On 05/01/2010 07:28 PM, Dmitrijs Ledkovs wrote: > On 1 May 2010 18:19, Junio C Hamano wrote: >> Dmitrijs Ledkovs writes: >> >>> On 1 May 2010 17:36, Andreas Schwab wrote: >>>> Giedrius Slavinskas writes: >>>> >>>>> git fast-import does not support commits with more than one author. I >>>>> try to import bzr repository and it crashes. >>>> >>>> You can find a patch here: >>>> >>>> >>>> Andreas. >>> >>> Although this is fine shouldn't we put the additional authors to the >>> signed-off: lines in the git commit message? >> >> If an author didn't sign-off in the log message, a tool shouldn't add it >> automatically. Doing so makes S-o-b meaningless. >> > > Fair enough. I'm justing thinking on how to support round-tripping to > bzr with import/export cause there are a few other properties bzr > needs to recreate identical repository. Is it more appropriate for the > marks format revision (bzr side of it)? Add Co-authored-by: Some One and parse that when sending back to bzr. That way you get attribution properly in both tools, in a way. -- Andreas Ericsson andreas.ericsson@op5.se OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace. ```