# [PATCH] gitweb: Silence 'Variable VAR may be unavailable' warnings

1 messages from 2010-04-30 to 2010-04-30. Participants: Jakub Narebski.
Thread: https://gitlist.dev/t/23639

## Jakub Narebski, 2010-04-30 16:30

Subject: [PATCH] gitweb: Silence 'Variable VAR may be unavailable' warnings
Message-ID: <20100430162934.11548.7015.stgit@localhost.localdomain>
URL: https://gitlist.dev/e/20100430162934.11548.7015.stgit%40localhost.localdomain

```
When $projects_list points to a directory, and git_get_projects_list
scans this directory for repositories, there can be generated the
following warnings (for persistent services like mod_perl or plackup):

  Variable "$project_maxdepth" may be unavailable at gitweb.cgi line 2443.
  Variable "$projectroot" may be unavailable at gitweb.cgi line 2451.

Those are false positives; silence those warnings by explicitely
declaring $project_maxdepth and $projectroot with 'our', as global
variables, in anonymous subrotine passed to File::Find::find.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Those warnings do not appear when run as simple CGI script, so test
suite could not catch them.

 gitweb/gitweb.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7d9b660..d6cbfa9 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2433,6 +2433,9 @@ sub git_get_projects_list {
 			follow_skip => 2, # ignore duplicates
 			dangling_symlinks => 0, # ignore dangling symlinks, silently
 			wanted => sub {
+				# global variables
+				our $project_maxdepth;
+				our $projectroot;
 				# skip project-list toplevel, if we get it.
 				return if (m!^[/.]$!);
 				# only directories can be git repositories

```