# [PATCH] git-instaweb: pass through invoking user's path to gitweb CGI scripts 3 messages from 2010-04-15 to 2010-04-17. Participants: Chris Webb, Eric Wong, Junio C Hamano. Thread: https://gitlist.dev/t/23477 ## Chris Webb, 2010-04-15 13:29 Subject: [PATCH] git-instaweb: pass through invoking user's path to gitweb CGI scripts Message-ID: <59ee8c7a3052ed747b5dbaa0a1d0e51aded9c413.1271337968.git.chris@arachsys.com> URL: https://gitlist.dev/e/59ee8c7a3052ed747b5dbaa0a1d0e51aded9c413.1271337968.git.chris%40arachsys.com ``` When used with lighttpd or mongoose, git-instaweb previously passed a hard-coded, default value of PATH to the gitweb CGI script. Use the invoking user's value for PATH for this instead. (This is already implicitly the behaviour for other web servers supported by git-instaweb.) Signed-off-by: Chris Webb --- git-instaweb.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-instaweb.sh b/git-instaweb.sh index d4941a9..f608014 100755 --- a/git-instaweb.sh +++ b/git-instaweb.sh @@ -212,7 +212,7 @@ server.errorlog = "$fqgitdir/gitweb/error.log" # variable above and uncomment this #accesslog.filename = "$fqgitdir/gitweb/access.log" -setenv.add-environment = ( "PATH" => "/usr/local/bin:/usr/bin:/bin" ) +setenv.add-environment = ( "PATH" => env.PATH ) cgi.assign = ( ".cgi" => "" ) @@ -361,7 +361,7 @@ error_log $fqgitdir/gitweb/error.log access_log $fqgitdir/gitweb/access.log #cgi setup -cgi_env PATH=/usr/local/bin:/usr/bin:/bin,GIT_DIR=$GIT_DIR,GIT_EXEC_PATH=$GIT_EXEC_PATH +cgi_env PATH=$PATH,GIT_DIR=$GIT_DIR,GIT_EXEC_PATH=$GIT_EXEC_PATH cgi_interp $PERL cgi_ext cgi,pl -- 1.7.0.3 ``` ## Eric Wong, 2010-04-16 06:34 Subject: Re: [PATCH] git-instaweb: pass through invoking user's path to gitweb CGI scripts Message-ID: <20100416063432.GA27115@dcvr.yhbt.net> URL: https://gitlist.dev/e/20100416063432.GA27115%40dcvr.yhbt.net In-Reply-To: <59ee8c7a3052ed747b5dbaa0a1d0e51aded9c413.1271337968.git.chris@arachsys.com> ``` Chris Webb wrote: > When used with lighttpd or mongoose, git-instaweb previously passed a > hard-coded, default value of PATH to the gitweb CGI script. Use the invoking > user's value for PATH for this instead. (This is already implicitly the > behaviour for other web servers supported by git-instaweb.) > > Signed-off-by: Chris Webb Looks good to me, thanks Chris. Acked-by: Eric Wong > --- > git-instaweb.sh | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/git-instaweb.sh b/git-instaweb.sh > index d4941a9..f608014 100755 > --- a/git-instaweb.sh > +++ b/git-instaweb.sh > @@ -212,7 +212,7 @@ server.errorlog = "$fqgitdir/gitweb/error.log" > # variable above and uncomment this > #accesslog.filename = "$fqgitdir/gitweb/access.log" > > -setenv.add-environment = ( "PATH" => "/usr/local/bin:/usr/bin:/bin" ) > +setenv.add-environment = ( "PATH" => env.PATH ) > > cgi.assign = ( ".cgi" => "" ) > > @@ -361,7 +361,7 @@ error_log $fqgitdir/gitweb/error.log > access_log $fqgitdir/gitweb/access.log > > #cgi setup > -cgi_env PATH=/usr/local/bin:/usr/bin:/bin,GIT_DIR=$GIT_DIR,GIT_EXEC_PATH=$GIT_EXEC_PATH > +cgi_env PATH=$PATH,GIT_DIR=$GIT_DIR,GIT_EXEC_PATH=$GIT_EXEC_PATH > cgi_interp $PERL > cgi_ext cgi,pl > > -- > 1.7.0.3 > ``` ## Junio C Hamano, 2010-04-17 17:32 Subject: Re: [PATCH] git-instaweb: pass through invoking user's path to gitweb CGI scripts Message-ID: <7vd3xy2dds.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vd3xy2dds.fsf%40alter.siamese.dyndns.org In-Reply-To: <59ee8c7a3052ed747b5dbaa0a1d0e51aded9c413.1271337968.git.chris@arachsys.com> ``` Thanks, both. Will queue. ```