# Tests with broken && chains in pu 5 messages from 2010-04-04 to 2010-04-04. Participants: Johannes Sixt, Sverre Rabbelier, Chris Webb, Junio C Hamano. Thread: https://gitlist.dev/t/23331 ## Johannes Sixt, 2010-04-04 20:08 Subject: Tests with broken && chains in pu Message-ID: <201004042208.58939.j6t@kdbg.org> URL: https://gitlist.dev/e/201004042208.58939.j6t%40kdbg.org ``` Junio, two commits in pu currently add tests with broken && chains: abbfd017 in cw/ws-indent-with-tab: diff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh index 9e57f80..e92eab0 100755 --- a/t/t4015-diff-whitespace.sh +++ b/t/t4015-diff-whitespace.sh @@ -354,7 +354,7 @@ test_expect_success 'check tabs and spaces as indentation (indent-with-non-tab: test_expect_success 'check tabs as indentation (tab-in-indent: off)' ' - git config core.whitespace "-tab-in-indent" + git config core.whitespace "-tab-in-indent" && echo " foo ();" > x && git diff --check @@ -378,7 +378,7 @@ test_expect_success 'check tabs and spaces as indentation (tab-in-indent: on)' ' test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' ' - git config core.whitespace "tab-in-indent,indent-with-non-tab" + git config core.whitespace "tab-in-indent,indent-with-non-tab" && echo "foo ();" > x && test_must_fail git diff --check @@ -386,7 +386,7 @@ test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' ' test_expect_success 'check tab-in-indent excluded from wildcard whitespace attribute' ' - git config --unset core.whitespace + git config --unset core.whitespace && echo "x whitespace" > .gitattributes && echo " foo ();" > x && git diff --check && c8eeb6301 in sr/remote-helper-export diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh index 33f546b..eb31709 100755 --- a/t/t5800-remote-helpers.sh +++ b/t/t5800-remote-helpers.sh @@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands' test_expect_success 'setup repository' ' git init --bare server/.git && - git clone server public + git clone server public && (cd public && echo content >file && git add file && @@ -18,7 +18,7 @@ test_expect_success 'setup repository' ' ' test_expect_success 'cloning from local repo' ' - git clone "testgit::${PWD}/server" localclone + git clone "testgit::${PWD}/server" localclone && test_cmp public/file localclone/file ' ``` ## Sverre Rabbelier, 2010-04-04 20:15 Subject: Re: Tests with broken && chains in pu Message-ID: URL: https://gitlist.dev/e/v2yfabb9a1e1004041315x999376f6m7dd689b529ce33d8%40mail.gmail.com In-Reply-To: <201004042208.58939.j6t@kdbg.org> ``` Heya, On Sun, Apr 4, 2010 at 15:08, Johannes Sixt wrote: > two commits in pu currently add tests with broken && chains: > diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh > index 33f546b..eb31709 100755 > --- a/t/t5800-remote-helpers.sh > +++ b/t/t5800-remote-helpers.sh > @@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands' > >  test_expect_success 'setup repository' ' >        git init --bare server/.git && > -       git clone server public > +       git clone server public && >        (cd public && >         echo content >file && >         git add file && > @@ -18,7 +18,7 @@ test_expect_success 'setup repository' ' >  ' > >  test_expect_success 'cloning from local repo' ' > -       git clone "testgit::${PWD}/server" localclone > +       git clone "testgit::${PWD}/server" localclone && >        test_cmp public/file localclone/file >  ' Thanks for noticing, may I ask how you noticed? Do you have a script or was it manual review? -- Cheers, Sverre Rabbelier ``` ## Johannes Sixt, 2010-04-04 20:41 Subject: Re: Tests with broken && chains in pu Message-ID: <201004042241.17655.j6t@kdbg.org> URL: https://gitlist.dev/e/201004042241.17655.j6t%40kdbg.org In-Reply-To: ``` On Sonntag, 4. April 2010, Sverre Rabbelier wrote: > Thanks for noticing, may I ask how you noticed? Do you have a script > or was it manual review? It was manual review. I reviewed the patches in pu because I noticed a broken && chain in a recently submitted patch, but I didn't remember which one it was. So I took the time to look at all new test cases in pu after Junio's recent What's in git message. -- Hannes ``` ## Chris Webb, 2010-04-04 20:45 Subject: Re: Tests with broken && chains in pu Message-ID: <20100404204509.GA31315@arachsys.com> URL: https://gitlist.dev/e/20100404204509.GA31315%40arachsys.com In-Reply-To: <201004042208.58939.j6t@kdbg.org> ``` Johannes Sixt writes: > two commits in pu currently add tests with broken && chains: > abbfd017 in cw/ws-indent-with-tab: Thanks for spotting this mistake Johannes. Should I resubmit a corrected version of the patch, Junio, or do you prefer to squash fixups directly into the pu branch? Best wishes, Chris. ``` ## Junio C Hamano, 2010-04-04 21:28 Subject: Re: Tests with broken && chains in pu Message-ID: <7vochy7vrm.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vochy7vrm.fsf%40alter.siamese.dyndns.org In-Reply-To: <201004042208.58939.j6t@kdbg.org> ``` Thanks; will squash these in and rebuild the topics. ```