# [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files

3 messages from 2010-04-01 to 2010-04-01. Participants: Mark Rada, Jakub Narebski, Junio C Hamano.
Thread: https://gitlist.dev/t/23278

## Mark Rada, 2010-04-01 05:35

Subject: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files
Message-ID: <4BB430A0.7040700@mailservices.uwaterloo.ca>
URL: https://gitlist.dev/e/4BB430A0.7040700%40mailservices.uwaterloo.ca

```
Signed-off-by: Mark Rada <marada@uwaterloo.ca>

---

	No changes since the previous version.

 .gitignore |    1 +
 Makefile   |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/.gitignore b/.gitignore
index 7b3acb7..4c24152 100644
--- a/.gitignore
+++ b/.gitignore
@@ -156,6 +156,7 @@
 /git-core-*/?*
 /gitk-git/gitk-wish
 /gitweb/gitweb.cgi
+/gitweb/gitweb.min.*
 /test-chmtime
 /test-ctype
 /test-date
diff --git a/Makefile b/Makefile
index 6d73a8c..5384d33 100644
--- a/Makefile
+++ b/Makefile
@@ -2089,7 +2089,7 @@ clean:
 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
 	$(MAKE) -C Documentation/ clean
 ifndef NO_PERL
-	$(RM) gitweb/gitweb.cgi
+	$(RM) gitweb/gitweb.{cgi,min.*}
 	$(MAKE) -C perl clean
 endif
 ifndef NO_PYTHON
-- 
1.7.0.3.436.g45b2d

```

## Jakub Narebski, 2010-04-01 08:24

Subject: Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files
Message-ID: <201004011024.50615.jnareb@gmail.com>
URL: https://gitlist.dev/e/201004011024.50615.jnareb%40gmail.com
In-Reply-To: <4BB430A0.7040700@mailservices.uwaterloo.ca>

```
On Thu, 1 April 2010, Mark Rada wrote:

> Signed-off-by: Mark Rada <marada@uwaterloo.ca>

For what it's worth:
Acked-by: Jakub Narebski <jnareb@gmail.com> 

> diff --git a/Makefile b/Makefile
> index 6d73a8c..5384d33 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2089,7 +2089,7 @@ clean:
>  	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
>  	$(MAKE) -C Documentation/ clean
>  ifndef NO_PERL
> -	$(RM) gitweb/gitweb.cgi
> +	$(RM) gitweb/gitweb.{cgi,min.*}
>  	$(MAKE) -C perl clean
>  endif

Minor nit: this would be first line that uses {a,b} shell glob 
construct.  Why not write it as:

  -	$(RM) gitweb/gitweb.cgi
  +	$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*

-- 
Jakub Narebski
Poland

```

## Junio C Hamano, 2010-04-01 21:26

Subject: Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files
Message-ID: <7vaatmooeb.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vaatmooeb.fsf%40alter.siamese.dyndns.org
In-Reply-To: <201004011024.50615.jnareb@gmail.com>

```
Jakub Narebski <jnareb@gmail.com> writes:

>>  ifndef NO_PERL
>> -	$(RM) gitweb/gitweb.cgi
>> +	$(RM) gitweb/gitweb.{cgi,min.*}
>>  	$(MAKE) -C perl clean
>>  endif
>
> Minor nit: this would be first line that uses {a,b} shell glob 
> construct.  Why not write it as:
>
>   -	$(RM) gitweb/gitweb.cgi
>   +	$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*

Very good point and it is not a "minor nit"; I cannot apply the patch
without your fix.

My understanding is that you Ack 1 (with this fix), 2 (with another
paragraph in the log message), and 5.  Eric Acked 4 and 6 needs to be
reworked.  I wonder if anybody has comments on 3; I didn't look very
closely at it, but it looked sane to me.

With that understanding, I'll queue the whole thing to 'pu', so that they
can be reworked and replaced before hitting 'next'.

Thanks, all.

```