Jon SeymourThe rationale for this change is that the previous behaviour did not allow the user to make an informed decision about the likely consequences of "Use Local Version" or "Stage to commit" for conflicted files. The reason for this is that in the conflicted case, successfully staged remote hunks are effectively invisible to user (via the git-gui interface) and hence cannot inform the user's decision making process.
For example, previously use of "Use Local Version" would silently discard from the index, and the working tree any successfully merged remote hunks. Since these hunks had never been displayed to the user, this loss would be unnoticed and unexpected.
In the case of "Stage to commit", the successfully merged remote hunks would be preserved in the index and the working tree but the fact that there are successfully merged remote hunks would not be not visible until after the "Stage to commit" action has been taken. If the user did not check diff _after_ taking the action, the user may have unwittingly commit changes from a remote hunk that she was not aware of.
With this change, in the case of conflicted paths only, git-gui displays what the index would contain if the current working tree copy was staged to the index as is. If there are successfully merged hunks from the remote branch in the index, then these will be visible in diff, thus making the potential consequences of both "Use Local Version" and "Stage to commit" directly visible prior to the user's action.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com> --- git-gui/lib/diff.tcl | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
Show changes to git-gui/lib/diff.tcl +5 −1
diff --git a/git-gui/lib/diff.tcl b/git-gui/lib/diff.tcl index e7b1986..a017fba 100644 --- a/git-gui/lib/diff.tcl +++ b/git-gui/lib/diff.tcl @@ -300,7 +300,11 @@ proc start_show_diff {cont_info {add_opts {}}} { } if {$w eq $ui_index} { lappend cmd [PARENT] - } + } else { + if {$is_unmerged} { + lappend cmd "HEAD" + } + } if {$add_opts ne {}} { eval lappend cmd $add_opts } else {
-- 1.6.6.1