malformed threads when using both --in-reply-to and --compose with git send-email

Sylvain Rabot· Mar 29, 2010, 22:49 UTC · lore

Hey,

I don't know if it's the wanted behavior but It seemed odd to me.

If I want to send a series of patches to an already started thread using --in-reply-to option and --compose this is what I would get :

git send-email --to git@vger.kernel.org --compose --in-reply-to <Message #2> --format-patch HEAD~2

+ Message #1
  + Message #2
    + [PATCH 0/2] My Serie of patches
    + [PATCH 1/2] My first patch
    + [PATCH 2/2] My second patch

I would have expected something more like this which is done when starting a new thread :

+ Message #1
  + Message #2
    + [PATCH 0/2] My Serie of patcher (In-Reply-To : <Message #2>)
      + [PATCH 1/2] My first patch (In-Reply-To : <My Serie of patches>)
      + [PATCH 2/2] My second patch (In-Reply-To : <My Serie of
patches>)

Regards.

-- 
Sylvain Rabot <sylvain@abstraction.fr>

Marc Branchaud· Mar 30, 2010, 14:12 UTC · re: Sylvain Rabot · lore

Re: malformed threads when using both --in-reply-to and --compose with git send-email

Sylvain Rabot wrote:

Show 25 quoted lines

> Hey,
> 
> I don't know if it's the wanted behavior but It seemed odd to me.
> 
> If I want to send a series of patches to an already started thread using
> --in-reply-to option and --compose this is what I would get :
> 
> git send-email --to git@vger.kernel.org --compose --in-reply-to <Message
> #2> --format-patch HEAD~2
> 
> + Message #1
>   + Message #2
>     + [PATCH 0/2] My Serie of patches
>     + [PATCH 1/2] My first patch
>     + [PATCH 2/2] My second patch
> 
> I would have expected something more like this which is done when
> starting a new thread :
> 
> + Message #1
>   + Message #2
>     + [PATCH 0/2] My Serie of patcher (In-Reply-To : <Message #2>)
>       + [PATCH 1/2] My first patch (In-Reply-To : <My Serie of patches>)
>       + [PATCH 2/2] My second patch (In-Reply-To : <My Serie of
> patches>)

I encountered this as well and agree with you that the latter would be better. --compose should only apply the --in-reply-to value to the composed message.

Care to make a patch?

M.