# [PATCH] fast-export: don't segfault when marks file cannot be opened 3 messages from 2010-03-28 to 2010-03-28. Participants: Sverre Rabbelier, Junio C Hamano. Thread: https://gitlist.dev/t/23212 ## Sverre Rabbelier, 2010-03-28 05:42 Subject: [PATCH] fast-export: don't segfault when marks file cannot be opened Message-ID: <1269754968-24961-1-git-send-email-srabbelier@gmail.com> URL: https://gitlist.dev/e/1269754968-24961-1-git-send-email-srabbelier%40gmail.com ``` The error function only prints an error message, resulting in a segfault if we later on try to fprintf to a NULL handle. Fix this by using die_errno instead. Signed-off-by: Sverre Rabbelier --- This has been proken ever since this functionality was added in df6a7ff7 (add importing and exporting of revision marks) on Jun 11 2008 by Pieter de Bie (cc-ed). All other error calls seem to be appropriate. This should probably be applied to maint? builtin/fast-export.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/fast-export.c b/builtin/fast-export.c index b0a4029..963e89b 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c @@ -503,7 +503,7 @@ static void export_marks(char *file) f = fopen(file, "w"); if (!f) - error("Unable to open marks file %s for writing.", file); + die_errno("Unable to open marks file %s for writing", file); for (i = 0; i < idnums.size; i++) { if (deco->base && deco->base->type == 1) { -- 1.7.0.2.333.g70ce.dirty ``` ## Sverre Rabbelier, 2010-03-28 05:45 Subject: Re: [PATCH] fast-export: don't segfault when marks file cannot be opened Message-ID: URL: https://gitlist.dev/e/fabb9a1e1003272245gc1de70ar216997ca11bc2038%40mail.gmail.com In-Reply-To: <1269754968-24961-1-git-send-email-srabbelier@gmail.com> ``` Heya, On Sat, Mar 27, 2010 at 23:42, Sverre Rabbelier wrote: > -               error("Unable to open marks file %s for writing.", file); > +               die_errno("Unable to open marks file %s for writing", file); Heh, and of course I manage to mess up a 3-byte patch. The '.' removal shouldn't be there of course. -- Cheers, Sverre Rabbelier ``` ## Junio C Hamano, 2010-03-28 16:26 Subject: Re: [PATCH] fast-export: don't segfault when marks file cannot be opened Message-ID: <7v7how5s51.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v7how5s51.fsf%40alter.siamese.dyndns.org In-Reply-To: ``` Sverre Rabbelier writes: > Heh, and of course I manage to mess up a 3-byte patch. The '.' removal > shouldn't be there of course. Will fix it up here. Thanks. ```