threads / discuss / 23187

request for enhancement: gitk highlight whitespace

Subject: request for enhancement: gitk highlight whitespace

## tl;dr

2 messages between Mar 26, 2010 and Mar 26, 2010.

replies: 1people: 2as markdown or json

Simon Braunschmidt· Mar 26, 2010, 14:19 UTC · lore
Hi

It would be great if I could teach gitk to better highlight whitespace changes in the diff view.

Every once in a while (and again today) I have to review patches that "fix whitespace". Allthough the fixes are usually trivial, I have to check them, which is not trivial with the gitk display. Also I often mistakenly accept changes after review with gitk that turn out to contain a mix of tabs/whitespace etc.

I searched the mailinglist (for gitk whitespace) and asked on irc, yet nobody seemed to care so far.

What do you think about it?

Regards,Gruessle Simon

Oliver Kullmann· Mar 26, 2010, 16:21 UTC · re: Simon Braunschmidt · lore

Re: request for enhancement: gitk highlight whitespace

Yeah, that would be good. Don't know whether it has something to do with a change in Git (I'm using 1.7.0.1), but recently I got quite a few submissions where gitk shows lines as changed, but I couldn't find out what it was.

A general option to show explicitly the change would be a good thing.

Oliver

P.S. This would also be helpful for long lines (yet it's a pain with gitk to find out where the change is).

On Fri, Mar 26, 2010 at 03:19:17PM +0100, Simon Braunschmidt wrote:
Show 22 quoted lines
> Hi
> 
> It would be great if I could teach gitk to better highlight 
> whitespace changes in the diff view.
> 
> Every once in a while (and again today) I have to review 
> patches that "fix whitespace". Allthough the fixes are usually 
> trivial, I have to check them, which is not trivial with the gitk 
> display. Also I often mistakenly accept changes after 
> review with gitk that turn out to contain a mix of 
> tabs/whitespace etc. 
> 
> I searched the mailinglist (for gitk whitespace) and asked on irc, yet 
> nobody seemed to care so far.
> 
> What do you think about it?
> 
> Regards,Gruessle
> Simon
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org

← back to recent threads