threads / discuss / 23090

[PATCHv2] Add ignore and clean rules for gitweb.min.js

Subject: [PATCHv2] Add ignore and clean rules for gitweb.min.js

## tl;dr

2 messages between Mar 19, 2010 and Mar 20, 2010.

replies: 1people: 1as markdown or json

Mark Rada· Mar 19, 2010, 21:40 UTC · lore
Signed-off-by: Mark Rada <marada@uwaterloo.ca>
---

The instaweb patch from earlier was about making the instaweb script aware that users can generate a minified version of gitweb.js. I think the stuff I am doing in this patch was just forgotten when JSMIN support was first added for gitweb.

Junio, I went and changed the clean target changes according to your comment.

 .gitignore |    1 +
 Makefile   |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/.gitignore b/.gitignore
index 7b3acb7..4c24152 100644
--- a/.gitignore
+++ b/.gitignore
@@ -156,6 +156,7 @@
 /git-core-*/?*
 /gitk-git/gitk-wish
 /gitweb/gitweb.cgi
+/gitweb/gitweb.min.*
 /test-chmtime
 /test-ctype
 /test-date
diff --git a/Makefile b/Makefile
index f80b25e..aa1996d 100644
--- a/Makefile
+++ b/Makefile
@@ -2077,7 +2077,7 @@ clean:
 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
 	$(MAKE) -C Documentation/ clean
 ifndef NO_PERL
-	$(RM) gitweb/gitweb.cgi
+	$(RM) gitweb/{gitweb.cgi,gitweb.min.js}
 	$(MAKE) -C perl clean
 endif
 ifndef NO_PYTHON
-- 
1.7.0.2.279.gf1ba1c
Mark Rada· Mar 20, 2010, 03:05 UTC · lore

Re: [PATCHv2] Add ignore and clean rules for gitweb.min.js

Junio,

I went and added some other things that should probably be squashed into this commit, unless it is too late. Updating documentation for jsmin and adding autoconfigure support for it.

-- 
Mark Rada (ferrous26)
marada@uwaterloo.ca


On 10-03-19 5:59 PM, Junio C Hamano wrote:
> Mark Rada <marada@uwaterloo.ca> writes:
> 
>> Signed-off-by: Mark Rada <marada@uwaterloo.ca>
>>
>> ---
>>
>> The instaweb patch from earlier was about making the instaweb
>> script aware that users can generate a minified version of 
>> gitweb.js. I think the stuff I am doing in this patch was just
>> forgotten when JSMIN support was first added for gitweb.
>>
>> Junio, I went and changed the clean target changes according
>> to your comment.
> 
> Thanks, will queue.

← back to recent threads