threads / rfc / 23084

RFC patchShip bash completion package in RPMs

Subject: [PATCH/RFC] Ship bash completion package in RPMs

## tl;dr

3 messages between Mar 19, 2010 and Mar 19, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ian Ward Comfort· Mar 19, 2010, 18:26 UTC · lore

RPM-based distributions tend to have bash. Let's add the bash completion routines to our core RPM in the standard location.

---

... Unless this is undesirable because the completion support is in contrib/? Anyway, having this upstream would save me some patching, so I thought I'd give it a shot.

 git.spec.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Show changes to git.spec.in +4 −0

diff --git a/git.spec.in b/git.spec.in
index ee74a5e..d2527c3 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -127,6 +127,9 @@ find $RPM_BUILD_ROOT -type f -name perllocal.pod -exec rm -f {} ';'
 rm -rf $RPM_BUILD_ROOT%{_mandir}
 %endif
 
+mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/bash_completion.d
+install -m 644 -T contrib/completion/git-completion.bash $RPM_BUILD_ROOT%{_sysconfdir}/bash_completion.d/git
+
 %clean
 rm -rf $RPM_BUILD_ROOT
 
@@ -136,6 +139,7 @@ rm -rf $RPM_BUILD_ROOT
 %doc README COPYING Documentation/*.txt
 %{!?_without_docs: %doc Documentation/*.html Documentation/howto}
 %{!?_without_docs: %doc Documentation/technical}
+%{_sysconfdir}/bash_completion.d
 
 %files svn
 %defattr(-,root,root)

-- 
1.7.0.2

Ben Walton· Mar 19, 2010, 18:43 UTC · re: Ian Ward Comfort · lore

Re: [PATCH/RFC] Ship bash completion package in RPMs

Excerpts from Ian Ward Comfort's message of Fri Mar 19 14:26:53 -0400 2010:

Hi Ian,

> RPM-based distributions tend to have bash. Let's add the bash
> completion routines to our core RPM in the standard location.

I'd like to see this change too and have been tempted to submit it myself.

The only thing I'd (possibly) change, which speaks to your comments about contrib/, would be to make it conditional, requiring the builder to enable it specifically during the rpmbuild. Alternately, it could be split out to a git-completion subpackage?

Personally, I'm ok with what you've done here as we always do this ourselves.

Thanks! -Ben

-- 
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

Ian Ward Comfort· Mar 19, 2010, 18:52 UTC · re: Ben Walton · lore

Re: [PATCH/RFC] Ship bash completion package in RPMs

On 19 Mar 2010, at 11:43 AM, Ben Walton wrote:

Show 12 quoted lines

> Excerpts from Ian Ward Comfort's message of Fri Mar 19 14:26:53  
> -0400 2010:
>> RPM-based distributions tend to have bash. Let's add the bash  
>> completion routines to our core RPM in the standard location.
>
> I'd like to see this change too and have been tempted to submit it  
> myself.
>
> The only thing I'd (possibly) change, which speaks to your comments  
> about contrib/, would be to make it conditional, requiring the  
> builder to enable it specifically during the rpmbuild.  Alternately,  
> it could be split out to a git-completion subpackage?

I'd be happy to implement either of these alternatives, if we can gather a reasonable consensus around either.

-- 
Ian Ward Comfort <icomfort@stanford.edu>
Systems Team Lead, Academic Computing Services, Stanford University