threads / patch / 2304

patchcvsimport: catch error condition where cvs host disappears

Subject: [PATCH] cvsimport: catch error condition where cvs host disappears

## tl;dr

One message between Nov 2, 2005 and Nov 2, 2005. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Martin Langhoff· Nov 2, 2005, 00:48 UTC · lore

Add error handling for cases where the cvs server goes away unexpectedly. While I don't know why the cvs server is so erratic, we should definitely exit here before committing bogus files.

Signed-off-by: Martin Langhoff <martin@catalyst.net.nz>
---
 git-cvsimport.perl |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

applies-to: 5184f41aebc18fdd90c27b76b8fb230fda58fb84 2f441d6598e78b59181a084f9db5be7993971602

Show changes to git-cvsimport.perl +4 −0
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index bbb83fb..e3cad5a 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -337,6 +337,10 @@ sub file {
 	}
 	close ($fh);
 
+	if ($res eq '') {
+	    die "Looks like the server has gone away while fetching $fn $rev -- exiting!";
+	}
+
 	return ($name, $res);
 }
 
---
0.99.8.GIT

← back to recent threads